Skip to content

Conversation

@msyyc
Copy link
Member

@msyyc msyyc commented Dec 25, 2024

  • Fix ci to adopt different python version in different pipeline
  • Remove requirements.txt under folder eng
  • Don't install generator/requirements.txt since it is already included in generator/setup.py
  • Move all necessary dependencies into packages/typespec-python/dev_requirements.txt so that we only need to update here if there is dependencies update in @typespec/http-client-python

coverage==7.6.1
black==24.8.0
ptvsd==4.3.2
types-PyYAML==6.0.12.8
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coverage==7.6.9
black==24.10.0
setuptools==73.0.1
-r ../packages/typespec-python/dev_requirements.txt
Copy link
Member Author

@msyyc msyyc Dec 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although it is a little weird to install dependencies of subdirectory, we only need to update dependencies in one file after this change which is easier to maintain in the future.

pyright==1.1.391
pylint==3.2.7
tox==4.23.2
mypy==1.10.1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eng is only needed by pipeline for development, so there is no need to keep 2 files that requirements.txt and dev_requirements.txt, then I combined them into 1 file: dev_requirements.txt.

PyYAML==6.0.1
tomli==2.0.1
setuptools==69.2.0
json-rpc==1.14.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed dependencies are already declared in pygen.


# Add enable for useless disables
enable=useless-suppression
# enable=useless-suppression
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fix the CI to enable pylint for autorest.python then some tiny lint issues are reporeted. I disable some specific items and we could fix them in another PR.

@msyyc msyyc marked this pull request as ready for review January 3, 2025 05:55
@msyyc msyyc enabled auto-merge (squash) January 6, 2025 09:37
@msyyc msyyc merged commit 130f344 into main Jan 6, 2025
15 checks passed
@msyyc msyyc deleted the bump-2024-12-25 branch January 6, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants