Skip to content

update mypy for pipeline client in multiapi base #2990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iscai-msft merged 2 commits into from
Jan 6, 2025
Merged

update mypy for pipeline client in multiapi base #2990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6047913
update mypy for pipeline client in multiapi base
Jan 6, 2025
efbde11
add changeset
Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .chronus/changes/multiapi_mypy-2025-0-6-15-4-4.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
changeKind: fix
packages:
- "@autorest/python"
---

Improve mypy typing for pipeline clients in deprecated multiapi package
3 changes: 1 addition & 2 deletions packages/autorest.python/autorest/multiapi/templates/multiapi_service_client.py.jinja2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ def __init__(
**kwargs: Any
){{" -> None" if async_mode else "" }}:{% endmacro %}
{# actual template starts here #}
{% set pipeline_client = "ARMPipelineClient" if azure_arm else "PipelineClient" %}
{% set relative_path = ".." if async_mode else "." %}
{% set def = "async def" if async_mode else "def" %}
{% set async_prefix = "Async" if async_mode else "" %}
Expand Down Expand Up @@ -97,7 +96,7 @@ class {{ code_model.client.name }}({% if code_model.operation_mixin_group.mixin_
{{ p }},
{% endfor %}
]
self._client = {{ async_prefix }}{{ code_model.client.pipeline_client }}(base_url={{ code_model.host_variable_name }}, policies=_policies, **kwargs)
self._client: {{ async_prefix }}{{ code_model.client.pipeline_client }} = {{ async_prefix }}{{ code_model.client.pipeline_client }}(base_url={{ code_model.host_variable_name }}, policies=_policies, **kwargs)
super({{ code_model.client.name }}, self).__init__(
api_version=api_version,
profile=profile
Expand Down
2 changes: 1 addition & 1 deletion ...amples/specification/multiapi/generated/azure/multiapi/sample/_multiapi_service_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ def __init__(
policies.SensitiveHeaderCleanupPolicy(**kwargs) if self._config.redirect_policy else None,
self._config.http_logging_policy,
]
self._client = ARMPipelineClient(base_url=base_url, policies=_policies, **kwargs)
self._client: ARMPipelineClient = ARMPipelineClient(base_url=base_url, policies=_policies, **kwargs)
super(MultiapiServiceClient, self).__init__(api_version=api_version, profile=profile)

@classmethod
Expand Down
2 changes: 1 addition & 1 deletion ...es/specification/multiapi/generated/azure/multiapi/sample/aio/_multiapi_service_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ def __init__(
policies.SensitiveHeaderCleanupPolicy(**kwargs) if self._config.redirect_policy else None,
self._config.http_logging_policy,
]
self._client = AsyncARMPipelineClient(base_url=base_url, policies=_policies, **kwargs)
self._client: AsyncARMPipelineClient = AsyncARMPipelineClient(base_url=base_url, policies=_policies, **kwargs)
super(MultiapiServiceClient, self).__init__(api_version=api_version, profile=profile)

@classmethod
Expand Down
2 changes: 1 addition & 1 deletion ...thon/test/multiapi/Expected/AcceptanceTests/Multiapi/multiapi/_multiapi_service_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ def __init__(
policies.SensitiveHeaderCleanupPolicy(**kwargs) if self._config.redirect_policy else None,
self._config.http_logging_policy,
]
self._client = ARMPipelineClient(base_url=base_url, policies=_policies, **kwargs)
self._client: ARMPipelineClient = ARMPipelineClient(base_url=base_url, policies=_policies, **kwargs)
super(MultiapiServiceClient, self).__init__(
api_version=api_version,
profile=profile
Expand Down
2 changes: 1 addition & 1 deletion .../test/multiapi/Expected/AcceptanceTests/Multiapi/multiapi/aio/_multiapi_service_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ def __init__(
policies.SensitiveHeaderCleanupPolicy(**kwargs) if self._config.redirect_policy else None,
self._config.http_logging_policy,
]
self._client = AsyncARMPipelineClient(base_url=base_url, policies=_policies, **kwargs)
self._client: AsyncARMPipelineClient = AsyncARMPipelineClient(base_url=base_url, policies=_policies, **kwargs)
super(MultiapiServiceClient, self).__init__(
api_version=api_version,
profile=profile
Expand Down
2 changes: 1 addition & 1 deletion ...ltiapiCredentialDefaultPolicy/multiapicredentialdefaultpolicy/_multiapi_service_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def __init__(
policies.SensitiveHeaderCleanupPolicy(**kwargs) if self._config.redirect_policy else None,
self._config.http_logging_policy,
]
self._client = ARMPipelineClient(base_url=base_url, policies=_policies, **kwargs)
self._client: ARMPipelineClient = ARMPipelineClient(base_url=base_url, policies=_policies, **kwargs)
super(MultiapiServiceClient, self).__init__(
api_version=api_version,
profile=profile
Expand Down
2 changes: 1 addition & 1 deletion ...piCredentialDefaultPolicy/multiapicredentialdefaultpolicy/aio/_multiapi_service_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def __init__(
policies.SensitiveHeaderCleanupPolicy(**kwargs) if self._config.redirect_policy else None,
self._config.http_logging_policy,
]
self._client = AsyncARMPipelineClient(base_url=base_url, policies=_policies, **kwargs)
self._client: AsyncARMPipelineClient = AsyncARMPipelineClient(base_url=base_url, policies=_policies, **kwargs)
super(MultiapiServiceClient, self).__init__(
api_version=api_version,
profile=profile
Expand Down
2 changes: 1 addition & 1 deletion ...s/MultiapiCustomBaseUrl/multiapicustombaseurl/_multiapi_custom_base_url_service_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ def __init__(
policies.SensitiveHeaderCleanupPolicy(**kwargs) if self._config.redirect_policy else None,
self._config.http_logging_policy,
]
self._client = PipelineClient(base_url=base_url, policies=_policies, **kwargs)
self._client: PipelineClient = PipelineClient(base_url=base_url, policies=_policies, **kwargs)
super(MultiapiCustomBaseUrlServiceClient, self).__init__(
api_version=api_version,
profile=profile
Expand Down
2 changes: 1 addition & 1 deletion ...ltiapiCustomBaseUrl/multiapicustombaseurl/aio/_multiapi_custom_base_url_service_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ def __init__(
policies.SensitiveHeaderCleanupPolicy(**kwargs) if self._config.redirect_policy else None,
self._config.http_logging_policy,
]
self._client = AsyncPipelineClient(base_url=base_url, policies=_policies, **kwargs)
self._client: AsyncPipelineClient = AsyncPipelineClient(base_url=base_url, policies=_policies, **kwargs)
super(MultiapiCustomBaseUrlServiceClient, self).__init__(
api_version=api_version,
profile=profile
Expand Down
2 changes: 1 addition & 1 deletion .../Expected/AcceptanceTests/MultiapiDataPlane/multiapidataplane/_multiapi_service_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def __init__(
policies.SensitiveHeaderCleanupPolicy(**kwargs) if self._config.redirect_policy else None,
self._config.http_logging_policy,
]
self._client = PipelineClient(base_url=base_url, policies=_policies, **kwargs)
self._client: PipelineClient = PipelineClient(base_url=base_url, policies=_policies, **kwargs)
super(MultiapiServiceClient, self).__init__(
api_version=api_version,
profile=profile
Expand Down
2 changes: 1 addition & 1 deletion ...ected/AcceptanceTests/MultiapiDataPlane/multiapidataplane/aio/_multiapi_service_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def __init__(
policies.SensitiveHeaderCleanupPolicy(**kwargs) if self._config.redirect_policy else None,
self._config.http_logging_policy,
]
self._client = AsyncPipelineClient(base_url=base_url, policies=_policies, **kwargs)
self._client: AsyncPipelineClient = AsyncPipelineClient(base_url=base_url, policies=_policies, **kwargs)
super(MultiapiServiceClient, self).__init__(
api_version=api_version,
profile=profile
Expand Down
2 changes: 1 addition & 1 deletion ...ected/AcceptanceTests/MultiapiKeywordOnly/multiapikeywordonly/_multiapi_service_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def __init__(
policies.SensitiveHeaderCleanupPolicy(**kwargs) if self._config.redirect_policy else None,
self._config.http_logging_policy,
]
self._client = PipelineClient(base_url=base_url, policies=_policies, **kwargs)
self._client: PipelineClient = PipelineClient(base_url=base_url, policies=_policies, **kwargs)
super(MultiapiServiceClient, self).__init__(
api_version=api_version,
profile=profile
Expand Down
2 changes: 1 addition & 1 deletion ...d/AcceptanceTests/MultiapiKeywordOnly/multiapikeywordonly/aio/_multiapi_service_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def __init__(
policies.SensitiveHeaderCleanupPolicy(**kwargs) if self._config.redirect_policy else None,
self._config.http_logging_policy,
]
self._client = AsyncPipelineClient(base_url=base_url, policies=_policies, **kwargs)
self._client: AsyncPipelineClient = AsyncPipelineClient(base_url=base_url, policies=_policies, **kwargs)
super(MultiapiServiceClient, self).__init__(
api_version=api_version,
profile=profile
Expand Down
2 changes: 1 addition & 1 deletion ...iapi/Expected/AcceptanceTests/MultiapiNoAsync/multiapinoasync/_multiapi_service_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ def __init__(
policies.SensitiveHeaderCleanupPolicy(**kwargs) if self._config.redirect_policy else None,
self._config.http_logging_policy,
]
self._client = ARMPipelineClient(base_url=base_url, policies=_policies, **kwargs)
self._client: ARMPipelineClient = ARMPipelineClient(base_url=base_url, policies=_policies, **kwargs)
super(MultiapiServiceClient, self).__init__(
api_version=api_version,
profile=profile
Expand Down
2 changes: 1 addition & 1 deletion ...pi/Expected/AcceptanceTests/MultiapiSecurity/multiapisecurity/_multiapi_service_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def __init__(
policies.SensitiveHeaderCleanupPolicy(**kwargs) if self._config.redirect_policy else None,
self._config.http_logging_policy,
]
self._client = PipelineClient(base_url=base_url, policies=_policies, **kwargs)
self._client: PipelineClient = PipelineClient(base_url=base_url, policies=_policies, **kwargs)
super(MultiapiServiceClient, self).__init__(
api_version=api_version,
profile=profile
Expand Down
2 changes: 1 addition & 1 deletion ...xpected/AcceptanceTests/MultiapiSecurity/multiapisecurity/aio/_multiapi_service_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def __init__(
policies.SensitiveHeaderCleanupPolicy(**kwargs) if self._config.redirect_policy else None,
self._config.http_logging_policy,
]
self._client = AsyncPipelineClient(base_url=base_url, policies=_policies, **kwargs)
self._client: AsyncPipelineClient = AsyncPipelineClient(base_url=base_url, policies=_policies, **kwargs)
super(MultiapiServiceClient, self).__init__(
api_version=api_version,
profile=profile
Expand Down
2 changes: 1 addition & 1 deletion ...ceTests/MultiapiWithSubmodule/multiapiwithsubmodule/submodule/_multiapi_service_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ def __init__(
policies.SensitiveHeaderCleanupPolicy(**kwargs) if self._config.redirect_policy else None,
self._config.http_logging_policy,
]
self._client = ARMPipelineClient(base_url=base_url, policies=_policies, **kwargs)
self._client: ARMPipelineClient = ARMPipelineClient(base_url=base_url, policies=_policies, **kwargs)
super(MultiapiServiceClient, self).__init__(
api_version=api_version,
profile=profile
Expand Down
2 changes: 1 addition & 1 deletion ...sts/MultiapiWithSubmodule/multiapiwithsubmodule/submodule/aio/_multiapi_service_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ def __init__(
policies.SensitiveHeaderCleanupPolicy(**kwargs) if self._config.redirect_policy else None,
self._config.http_logging_policy,
]
self._client = AsyncARMPipelineClient(base_url=base_url, policies=_policies, **kwargs)
self._client: AsyncARMPipelineClient = AsyncARMPipelineClient(base_url=base_url, policies=_policies, **kwargs)
super(MultiapiServiceClient, self).__init__(
api_version=api_version,
profile=profile
Expand Down
2 changes: 1 addition & 1 deletion ...ython/test/multiapi/Expected/AcceptanceTests/multiapicombiner/multiapicombiner/_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ def __init__(
policies.SensitiveHeaderCleanupPolicy(**kwargs) if self._config.redirect_policy else None,
self._config.http_logging_policy,
]
self._client = ARMPipelineClient(base_url=base_url, policies=_policies, **kwargs)
self._client: ARMPipelineClient = ARMPipelineClient(base_url=base_url, policies=_policies, **kwargs)
super(MultiapiServiceClient, self).__init__(
api_version=api_version,
profile=profile
Expand Down
2 changes: 1 addition & 1 deletion ...n/test/multiapi/Expected/AcceptanceTests/multiapicombiner/multiapicombiner/aio/_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ def __init__(
policies.SensitiveHeaderCleanupPolicy(**kwargs) if self._config.redirect_policy else None,
self._config.http_logging_policy,
]
self._client = AsyncARMPipelineClient(base_url=base_url, policies=_policies, **kwargs)
self._client: AsyncARMPipelineClient = AsyncARMPipelineClient(base_url=base_url, policies=_policies, **kwargs)
super(MultiapiServiceClient, self).__init__(
api_version=api_version,
profile=profile
Expand Down
Loading