Skip to content

Conversation

@catalinaperalta
Copy link
Member

@catalinaperalta catalinaperalta commented Feb 28, 2025

@catalinaperalta catalinaperalta changed the title Move m2r code into autorest directly Move m2r code into autorest.python Feb 28, 2025
@catalinaperalta catalinaperalta force-pushed the m2r-update branch 2 times, most recently from ff52ce4 to 0099f5b Compare March 7, 2025 02:07
@catalinaperalta catalinaperalta marked this pull request as ready for review March 7, 2025 23:52
@catalinaperalta
Copy link
Member Author

catalinaperalta commented Mar 7, 2025

Temporarily pinned the http-client-python dependency to the artifact created in ci by the PR I linked above. After the typespec pr is merged in and released I'll revert that change.

The autorest.python checks show a test failing, any advice on how to make that one pass? It doesnt look like it's related to the m2r changes.

I tried to run npm run test locally but get this error:

> npm run test

> @autorest/python@6.29.0 test
> tsx ./scripts/eng/run-tests.ts --validFolders azure/legacy azure/version-tolerant vanilla/legacy vanilla/version-tolerant dpg/version-tolerant

Running ci for folder azure/legacy...
'FOLDER' is not recognized as an internal or external command,
operable program or batch file.
Command failed: FOLDER=azure/legacy tox -c ./test/azure/legacy/tox.ini -e ci
Error executing command for folder azure/legacy: Command failed: FOLDER=azure/legacy tox -c ./test/azure/legacy/tox.ini -e ci
npm error Lifecycle script `test` failed with error:
npm error code 1
npm error path C:\Users\caperal\repos\autorest.python\packages\autorest.python
npm error workspace @autorest/python@6.29.0
npm error location C:\Users\caperal\repos\autorest.python\packages\autorest.python
npm error command failed
npm error command C:\WINDOWS\system32\cmd.exe /d /s /c tsx ./scripts/eng/run-tests.ts --validFolders azure/legacy azure/version-tolerant vanilla/legacy vanilla/version-tolerant dpg/version-tolerant

NOTE: the typespec checks are failing because when using the artifact download link some file paths are too long during regeneration.

cc @msyyc hopefully you can take a look on your Monday

@msyyc
Copy link
Member

msyyc commented Mar 10, 2025

Temporarily pinned the http-client-python dependency to the artifact created in ci by the PR I linked above. After the typespec pr is merged in and released I'll revert that change.

The autorest.python checks show a test failing, any advice on how to make that one pass? It doesnt look like it's related to the m2r changes.

I tried to run npm run test locally but get this error:

> npm run test

> @autorest/python@6.29.0 test
> tsx ./scripts/eng/run-tests.ts --validFolders azure/legacy azure/version-tolerant vanilla/legacy vanilla/version-tolerant dpg/version-tolerant

Running ci for folder azure/legacy...
'FOLDER' is not recognized as an internal or external command,
operable program or batch file.
Command failed: FOLDER=azure/legacy tox -c ./test/azure/legacy/tox.ini -e ci
Error executing command for folder azure/legacy: Command failed: FOLDER=azure/legacy tox -c ./test/azure/legacy/tox.ini -e ci
npm error Lifecycle script `test` failed with error:
npm error code 1
npm error path C:\Users\caperal\repos\autorest.python\packages\autorest.python
npm error workspace @autorest/python@6.29.0
npm error location C:\Users\caperal\repos\autorest.python\packages\autorest.python
npm error command failed
npm error command C:\WINDOWS\system32\cmd.exe /d /s /c tsx ./scripts/eng/run-tests.ts --validFolders azure/legacy azure/version-tolerant vanilla/legacy vanilla/version-tolerant dpg/version-tolerant

NOTE: the typespec checks are failing because when using the artifact download link some file paths are too long during regeneration.

cc @msyyc hopefully you can take a look on your Monday

I commit some fix to fix the CI.

@msyyc msyyc enabled auto-merge (squash) March 11, 2025 06:49
@msyyc msyyc merged commit cb913cb into main Mar 11, 2025
14 of 15 checks passed
@msyyc msyyc deleted the m2r-update branch March 11, 2025 07:13
@catalinaperalta
Copy link
Member Author

Thanks for helping with this PR @msyyc!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants