Skip to content

[python] persist changes to dict properties #3284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
msyyc wants to merge 8 commits into from
Closed

[python] persist changes to dict properties #3284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1245c26
Update dependencies
Dec 16, 2025
2a1ec4c
Add changelog .chronus/changes/auto-iscai-msft-python-fixDictSetting-…
Dec 16, 2025
60ec6d1
Update dependencies
Dec 16, 2025
ca315af
Update dependencies (2025-12-16 20:19:43)
Dec 16, 2025
e1b264e
Regenerate for typespec-python (2025-12-16 20:25:04)
Dec 16, 2025
19ae3e5
Regenerate for autorest.python (2025-12-16 20:39:46)
Dec 16, 2025
b38049e
fix unittests
Dec 16, 2025
e5b168c
merge
msyyc Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .chronus/changes/auto-iscai-msft-python-fixDictSetting-2025-11-16-14-5-28.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
changeKind: fix
packages:
- "@autorest/python"
- "@azure-tools/typespec-python"
---

Persist mutations to mutable properties when accessed via attribute syntax
31 changes: 30 additions & 1 deletion ...on/test/azure/generated/authentication-api-key/authentication/apikey/_utils/model_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,15 @@ def __contains__(self, key: typing.Any) -> bool:
return key in self._data

def __getitem__(self, key: str) -> typing.Any:
# Sync any cached deserialized value back to storage before returning
if hasattr(self, "_attr_to_rest_field"):
cache_attr = f"_deserialized_{key}"
if hasattr(self, cache_attr):
cached_value = object.__getattribute__(self, cache_attr)
rf = _get_rest_field(self._attr_to_rest_field, key)
if rf:
# Serialize the cached value back to storage
self._data[key] = _serialize(cached_value, rf._format)
return self._data.__getitem__(key)

def __setitem__(self, key: str, value: typing.Any) -> None:
Expand Down Expand Up @@ -1048,9 +1057,29 @@ def __get__(self, obj: Model, type=None): # pylint: disable=redefined-builtin
return item
if self._is_model:
return item
return _deserialize(self._type, _serialize(item, self._format), rf=self)
# For mutable types (dict, list, set), cache the deserialized object to allow mutations to persist
cache_attr = f"_deserialized_{self._rest_name}"
if hasattr(obj, cache_attr):
return object.__getattribute__(obj, cache_attr)

deserialized = _deserialize(self._type, _serialize(item, self._format), rf=self)

# Cache mutable types so mutations persist
try:
if isinstance(deserialized, (dict, list, set)):
object.__setattr__(obj, cache_attr, deserialized)
except AttributeError:
pass

return deserialized

def __set__(self, obj: Model, value) -> None:
# Clear the cached deserialized object when setting a new value
cache_attr = f"_deserialized_{self._rest_name}"
try:
object.__delattr__(obj, cache_attr)
except AttributeError:
pass
if value is None:
# we want to wipe out entries if users set attr to None
try:
Expand Down
31 changes: 30 additions & 1 deletion ...zure/generated/authentication-http-custom/authentication/http/custom/_utils/model_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,15 @@ def __contains__(self, key: typing.Any) -> bool:
return key in self._data

def __getitem__(self, key: str) -> typing.Any:
# Sync any cached deserialized value back to storage before returning
if hasattr(self, "_attr_to_rest_field"):
cache_attr = f"_deserialized_{key}"
if hasattr(self, cache_attr):
cached_value = object.__getattribute__(self, cache_attr)
rf = _get_rest_field(self._attr_to_rest_field, key)
if rf:
# Serialize the cached value back to storage
self._data[key] = _serialize(cached_value, rf._format)
return self._data.__getitem__(key)

def __setitem__(self, key: str, value: typing.Any) -> None:
Expand Down Expand Up @@ -1048,9 +1057,29 @@ def __get__(self, obj: Model, type=None): # pylint: disable=redefined-builtin
return item
if self._is_model:
return item
return _deserialize(self._type, _serialize(item, self._format), rf=self)
# For mutable types (dict, list, set), cache the deserialized object to allow mutations to persist
cache_attr = f"_deserialized_{self._rest_name}"
if hasattr(obj, cache_attr):
return object.__getattribute__(obj, cache_attr)

deserialized = _deserialize(self._type, _serialize(item, self._format), rf=self)

# Cache mutable types so mutations persist
try:
if isinstance(deserialized, (dict, list, set)):
object.__setattr__(obj, cache_attr, deserialized)
except AttributeError:
pass

return deserialized

def __set__(self, obj: Model, value) -> None:
# Clear the cached deserialized object when setting a new value
cache_attr = f"_deserialized_{self._rest_name}"
try:
object.__delattr__(obj, cache_attr)
except AttributeError:
pass
if value is None:
# we want to wipe out entries if users set attr to None
try:
Expand Down
31 changes: 30 additions & 1 deletion ...hon/test/azure/generated/authentication-oauth2/authentication/oauth2/_utils/model_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,15 @@ def __contains__(self, key: typing.Any) -> bool:
return key in self._data

def __getitem__(self, key: str) -> typing.Any:
# Sync any cached deserialized value back to storage before returning
if hasattr(self, "_attr_to_rest_field"):
cache_attr = f"_deserialized_{key}"
if hasattr(self, cache_attr):
cached_value = object.__getattribute__(self, cache_attr)
rf = _get_rest_field(self._attr_to_rest_field, key)
if rf:
# Serialize the cached value back to storage
self._data[key] = _serialize(cached_value, rf._format)
return self._data.__getitem__(key)

def __setitem__(self, key: str, value: typing.Any) -> None:
Expand Down Expand Up @@ -1048,9 +1057,29 @@ def __get__(self, obj: Model, type=None): # pylint: disable=redefined-builtin
return item
if self._is_model:
return item
return _deserialize(self._type, _serialize(item, self._format), rf=self)
# For mutable types (dict, list, set), cache the deserialized object to allow mutations to persist
cache_attr = f"_deserialized_{self._rest_name}"
if hasattr(obj, cache_attr):
return object.__getattribute__(obj, cache_attr)

deserialized = _deserialize(self._type, _serialize(item, self._format), rf=self)

# Cache mutable types so mutations persist
try:
if isinstance(deserialized, (dict, list, set)):
object.__setattr__(obj, cache_attr, deserialized)
except AttributeError:
pass

return deserialized

def __set__(self, obj: Model, value) -> None:
# Clear the cached deserialized object when setting a new value
cache_attr = f"_deserialized_{self._rest_name}"
try:
object.__delattr__(obj, cache_attr)
except AttributeError:
pass
if value is None:
# we want to wipe out entries if users set attr to None
try:
Expand Down
31 changes: 30 additions & 1 deletion ...ython/test/azure/generated/authentication-union/authentication/union/_utils/model_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,15 @@ def __contains__(self, key: typing.Any) -> bool:
return key in self._data

def __getitem__(self, key: str) -> typing.Any:
# Sync any cached deserialized value back to storage before returning
if hasattr(self, "_attr_to_rest_field"):
cache_attr = f"_deserialized_{key}"
if hasattr(self, cache_attr):
cached_value = object.__getattribute__(self, cache_attr)
rf = _get_rest_field(self._attr_to_rest_field, key)
if rf:
# Serialize the cached value back to storage
self._data[key] = _serialize(cached_value, rf._format)
return self._data.__getitem__(key)

def __setitem__(self, key: str, value: typing.Any) -> None:
Expand Down Expand Up @@ -1048,9 +1057,29 @@ def __get__(self, obj: Model, type=None): # pylint: disable=redefined-builtin
return item
if self._is_model:
return item
return _deserialize(self._type, _serialize(item, self._format), rf=self)
# For mutable types (dict, list, set), cache the deserialized object to allow mutations to persist
cache_attr = f"_deserialized_{self._rest_name}"
if hasattr(obj, cache_attr):
return object.__getattribute__(obj, cache_attr)

deserialized = _deserialize(self._type, _serialize(item, self._format), rf=self)

# Cache mutable types so mutations persist
try:
if isinstance(deserialized, (dict, list, set)):
object.__setattr__(obj, cache_attr, deserialized)
except AttributeError:
pass

return deserialized

def __set__(self, obj: Model, value) -> None:
# Clear the cached deserialized object when setting a new value
cache_attr = f"_deserialized_{self._rest_name}"
try:
object.__delattr__(obj, cache_attr)
except AttributeError:
pass
if value is None:
# we want to wipe out entries if users set attr to None
try:
Expand Down
31 changes: 30 additions & 1 deletion ...client-generator-core-access/specs/azure/clientgenerator/core/access/_utils/model_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,15 @@ def __contains__(self, key: typing.Any) -> bool:
return key in self._data

def __getitem__(self, key: str) -> typing.Any:
# Sync any cached deserialized value back to storage before returning
if hasattr(self, "_attr_to_rest_field"):
cache_attr = f"_deserialized_{key}"
if hasattr(self, cache_attr):
cached_value = object.__getattribute__(self, cache_attr)
rf = _get_rest_field(self._attr_to_rest_field, key)
if rf:
# Serialize the cached value back to storage
self._data[key] = _serialize(cached_value, rf._format)
return self._data.__getitem__(key)

def __setitem__(self, key: str, value: typing.Any) -> None:
Expand Down Expand Up @@ -1048,9 +1057,29 @@ def __get__(self, obj: Model, type=None): # pylint: disable=redefined-builtin
return item
if self._is_model:
return item
return _deserialize(self._type, _serialize(item, self._format), rf=self)
# For mutable types (dict, list, set), cache the deserialized object to allow mutations to persist
cache_attr = f"_deserialized_{self._rest_name}"
if hasattr(obj, cache_attr):
return object.__getattribute__(obj, cache_attr)

deserialized = _deserialize(self._type, _serialize(item, self._format), rf=self)

# Cache mutable types so mutations persist
try:
if isinstance(deserialized, (dict, list, set)):
object.__setattr__(obj, cache_attr, deserialized)
except AttributeError:
pass

return deserialized

def __set__(self, obj: Model, value) -> None:
# Clear the cached deserialized object when setting a new value
cache_attr = f"_deserialized_{self._rest_name}"
try:
object.__delattr__(obj, cache_attr)
except AttributeError:
pass
if value is None:
# we want to wipe out entries if users set attr to None
try:
Expand Down
31 changes: 30 additions & 1 deletion ...r-core-alternate-type/specs/azure/clientgenerator/core/alternatetype/_utils/model_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,15 @@ def __contains__(self, key: typing.Any) -> bool:
return key in self._data

def __getitem__(self, key: str) -> typing.Any:
# Sync any cached deserialized value back to storage before returning
if hasattr(self, "_attr_to_rest_field"):
cache_attr = f"_deserialized_{key}"
if hasattr(self, cache_attr):
cached_value = object.__getattribute__(self, cache_attr)
rf = _get_rest_field(self._attr_to_rest_field, key)
if rf:
# Serialize the cached value back to storage
self._data[key] = _serialize(cached_value, rf._format)
return self._data.__getitem__(key)

def __setitem__(self, key: str, value: typing.Any) -> None:
Expand Down Expand Up @@ -1062,9 +1071,29 @@ def __get__(self, obj: Model, type=None): # pylint: disable=redefined-builtin
return item
if self._is_model:
return item
return _deserialize(self._type, _serialize(item, self._format), rf=self)
# For mutable types (dict, list, set), cache the deserialized object to allow mutations to persist
cache_attr = f"_deserialized_{self._rest_name}"
if hasattr(obj, cache_attr):
return object.__getattribute__(obj, cache_attr)

deserialized = _deserialize(self._type, _serialize(item, self._format), rf=self)

# Cache mutable types so mutations persist
try:
if isinstance(deserialized, (dict, list, set)):
object.__setattr__(obj, cache_attr, deserialized)
except AttributeError:
pass

return deserialized

def __set__(self, obj: Model, value) -> None:
# Clear the cached deserialized object when setting a new value
cache_attr = f"_deserialized_{self._rest_name}"
try:
object.__delattr__(obj, cache_attr)
except AttributeError:
pass
if value is None:
# we want to wipe out entries if users set attr to None
try:
Expand Down
31 changes: 30 additions & 1 deletion ...or-core-api-version-header/client/alternateapiversion/service/header/_utils/model_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,15 @@ def __contains__(self, key: typing.Any) -> bool:
return key in self._data

def __getitem__(self, key: str) -> typing.Any:
# Sync any cached deserialized value back to storage before returning
if hasattr(self, "_attr_to_rest_field"):
cache_attr = f"_deserialized_{key}"
if hasattr(self, cache_attr):
cached_value = object.__getattribute__(self, cache_attr)
rf = _get_rest_field(self._attr_to_rest_field, key)
if rf:
# Serialize the cached value back to storage
self._data[key] = _serialize(cached_value, rf._format)
return self._data.__getitem__(key)

def __setitem__(self, key: str, value: typing.Any) -> None:
Expand Down Expand Up @@ -1048,9 +1057,29 @@ def __get__(self, obj: Model, type=None): # pylint: disable=redefined-builtin
return item
if self._is_model:
return item
return _deserialize(self._type, _serialize(item, self._format), rf=self)
# For mutable types (dict, list, set), cache the deserialized object to allow mutations to persist
cache_attr = f"_deserialized_{self._rest_name}"
if hasattr(obj, cache_attr):
return object.__getattribute__(obj, cache_attr)

deserialized = _deserialize(self._type, _serialize(item, self._format), rf=self)

# Cache mutable types so mutations persist
try:
if isinstance(deserialized, (dict, list, set)):
object.__setattr__(obj, cache_attr, deserialized)
except AttributeError:
pass

return deserialized

def __set__(self, obj: Model, value) -> None:
# Clear the cached deserialized object when setting a new value
cache_attr = f"_deserialized_{self._rest_name}"
try:
object.__delattr__(obj, cache_attr)
except AttributeError:
pass
if value is None:
# we want to wipe out entries if users set attr to None
try:
Expand Down
31 changes: 30 additions & 1 deletion ...erator-core-api-version-path/client/alternateapiversion/service/path/_utils/model_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,15 @@ def __contains__(self, key: typing.Any) -> bool:
return key in self._data

def __getitem__(self, key: str) -> typing.Any:
# Sync any cached deserialized value back to storage before returning
if hasattr(self, "_attr_to_rest_field"):
cache_attr = f"_deserialized_{key}"
if hasattr(self, cache_attr):
cached_value = object.__getattribute__(self, cache_attr)
rf = _get_rest_field(self._attr_to_rest_field, key)
if rf:
# Serialize the cached value back to storage
self._data[key] = _serialize(cached_value, rf._format)
return self._data.__getitem__(key)

def __setitem__(self, key: str, value: typing.Any) -> None:
Expand Down Expand Up @@ -1048,9 +1057,29 @@ def __get__(self, obj: Model, type=None): # pylint: disable=redefined-builtin
return item
if self._is_model:
return item
return _deserialize(self._type, _serialize(item, self._format), rf=self)
# For mutable types (dict, list, set), cache the deserialized object to allow mutations to persist
cache_attr = f"_deserialized_{self._rest_name}"
if hasattr(obj, cache_attr):
return object.__getattribute__(obj, cache_attr)

deserialized = _deserialize(self._type, _serialize(item, self._format), rf=self)

# Cache mutable types so mutations persist
try:
if isinstance(deserialized, (dict, list, set)):
object.__setattr__(obj, cache_attr, deserialized)
except AttributeError:
pass

return deserialized

def __set__(self, obj: Model, value) -> None:
# Clear the cached deserialized object when setting a new value
cache_attr = f"_deserialized_{self._rest_name}"
try:
object.__delattr__(obj, cache_attr)
except AttributeError:
pass
if value is None:
# we want to wipe out entries if users set attr to None
try:
Expand Down
Loading
Loading