Skip to content

Fix various linting issues, some refactoring and cleaning up #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
thaJeztah wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix various linting issues, some refactoring and cleaning up #39

thaJeztah wants to merge 3 commits into from

Conversation

@thaJeztah
Copy link
Contributor

@thaJeztah thaJeztah commented Jul 3, 2023

thaJeztah added 3 commits July 3, 2023 16:29
@thaJeztah
remove unused convertBytesToInteger()
db9a03d 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
explicitly ignore errors
0b3f7c0 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
minor cleanups/simplifications
3a38cd7 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah mentioned this pull request Jul 3, 2023
Open
@thaJeztah
Copy link
Contributor Author

thaJeztah commented Jul 3, 2023

/cc @dolmen ptal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cpuguy83 cpuguy83 cpuguy83 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thaJeztah @cpuguy83