[tcgc] crash if duplicate models / enums across namespaces when flattened with namespace flag or multi service #3775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 14, 2026 16:06
…cgc/duplicateModelNames
iscai-msft
requested review from
joheredi,
lmazuel,
m-nash and
srnagar
as code owners
microsoft-github-policy-service
bot
added
the
lib:tcgc
commit: |
Collaborator
|
All changed packages have been documented.
Show changes
|
added 2 commits
January 14, 2026 16:16
iscai-msft
requested review from
bterlson,
markcowl and
timotheeguerin
as code owners
tadelesh
reviewed
Jan 15, 2026
packages/typespec-client-generator-core/src/validations/types.ts
Outdated
Show resolved
Hide resolved
packages/typespec-client-generator-core/src/validations/types.ts
Outdated
Show resolved
Hide resolved
packages/typespec-client-generator-core/src/validations/types.ts
Outdated
Show resolved
Hide resolved
packages/typespec-client-generator-core/src/validations/types.ts
Outdated
Show resolved
Hide resolved
packages/typespec-client-generator-core/src/validations/types.ts
Outdated
Show resolved
Hide resolved
packages/typespec-client-generator-core/src/validations/types.ts
Outdated
Show resolved
Hide resolved
Member
|
Shall we have some discussions with TypeSpec team to see their suggestions for such kind of validation, since it will impact perf. |
added 12 commits
January 15, 2026 13:42
Collaborator
|
You can try these changes here
|
added 5 commits
January 20, 2026 17:16
…cgc/duplicateModelNames
…cgc/duplicateModelNames
tadelesh
reviewed
Jan 30, 2026
Comment on lines
+61
to
+67
| // Build a map of namespace names to their types for resolving string targets | ||
| const namedNamespaces = new Map<string, Namespace>(); | ||
| for (const ns of listAllUserDefinedNamespaces(tcgcContext)) { | ||
| if (ns.name) { | ||
| namedNamespaces.set(ns.name, ns); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Namespace name could have collision under different namespace. Since @clientLocation for operation with string could collide with existed namespace only limited to the first layer's namespace under @service namespace, the algorithm needs to be updated. But I think we could leave it for anther PR. Maybe revert the change for check in namespace is the fastest way.
| // Ensure we always run validation at least once (with AllScopes) | ||
| if (languageScopes.size === 0) { | ||
| languageScopes.add(AllScopes); | ||
| } |
Member
There was a problem hiding this comment.
When createSdkContext, we already have the emitter name, no need to all scopes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve: #1039