[Campus][Feature] 분실물 게시글 수정 기능 구현 #1241
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feature/#1214-lostandfound-edit
…b/KOIN_ANDROID into feature/#1214-lostandfound-edit
…om/BCSDLab/KOIN_ANDROID into feature/#1214-lostandfound-modify
kongwoojin
reviewed
Jan 23, 2026
Comment on lines
169
to
170
| onModifyArticleClick = { | ||
| navigateToModify(uiState.id) |
Member
There was a problem hiding this comment.
외부 변수를 사용하고 있으니 메모이제이션 처리를 하면 좋을 것 같습니다
Comment on lines
178
to
180
| val fileType = | ||
| context.contentResolver.getType(uri) | ||
| ?: "image/${fileName.split(".").last()}" |
Member
There was a problem hiding this comment.
이미지가 아닌 파일을 업로드 시도하는 경우 어떻게 되나요?
Collaborator
Author
There was a problem hiding this comment.
fileType.startsWith("image/") 으로 판단해서 image 인 경우만 하도록 하겠습니다.
type 이 null 인 경우는 그냥 무시하는게 나으려나요?
Collaborator
Author
There was a problem hiding this comment.
nullable 로 바꾸었습니다. null 일 경우 image 로 판단하지 않고 false 로 판단하여 등록되지 않습니다.
등록되지 않으면 toast message 를 올려줍니다.
Comment on lines
36
to
47
| ) : ViewModel(), | ||
| ContainerHost<LostAndFoundModifyState, LostAndFoundModifySideEffect> { | ||
| override val container = | ||
| container<LostAndFoundModifyState, LostAndFoundModifySideEffect>( | ||
| LostAndFoundModifyState(), | ||
| savedStateHandle | ||
| ) { | ||
| val articleId = savedStateHandle.get<Int>(ARTICLE_ID) | ||
| checkNotNull(articleId) | ||
| fetchLostAndFoundDetail(articleId) | ||
| } | ||
| private var originImages: List<ArticleLostAndFound.ArticleLostAndFoundImage> = emptyList() |
Collaborator
Author
There was a problem hiding this comment.
container 말씀하시는거죠? 일단 container 고치도록 하겠습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 개요
이슈 번호: #1214
PR 체크리스트
작업사항
작업사항의 상세한 설명
분실물 게시글 수정 api 에 잘못된 요청을 수정했습니다.
분실물 작성 에서의 ui component 를 공용 component 로 이동했습니다.
분실물 수정 기능을 추가했습니다.
논의 사항
스크린샷
추가내용