-
Notifications
You must be signed in to change notification settings - Fork 2
fix: 코인 어드민 API 수정 #2140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix: 코인 어드민 API 수정 #2140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kih1015
approved these changes
Jan 21, 2026
BaeJinho4028
approved these changes
Jan 22, 2026
Comment on lines
+56
to
+65
| // 레거시 필드 | ||
|
|
||
| @NotNull | ||
| @Enumerated(EnumType.STRING) | ||
| @Column(name = "team_type", nullable = false) | ||
| private TeamType teamType; | ||
|
|
||
| @Column(name = "can_create_admin", columnDefinition = "TINYINT") | ||
| private boolean canCreateAdmin = false; | ||
|
|
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
레거시 남겨놓은 이유가 있을까요
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
컬럼 drop이 지금 ci 과정에서 막히기도 하고, null값을 넣자하니 nullable이 아니기 때문에 수정해야하는데 nullable으로 수정할 바에 나중에 한번에 drop 하는게 편할 거 같아 유지했습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 개요
🚀 주요 변경 내용
can_create_admin권한을 삭제하고,super_admin으로 통합했습니다.team_type를 받지 않고, KOIN으로 고정으로 설정했습니다.💬 참고 사항
✅ Checklist (완료 조건)