Added loggers for debugging MAINT-38931 #553
Conversation
nibasbackbase
changed the title
| public Mono<BatchProductGroupTask> assignPermissionsBatch(BatchProductGroupTask task, | ||
| Map<User, Map<BusinessFunctionGroup, List<BaseProductGroup>>> usersPermissions) { | ||
|
|
||
| log.info("Assigning permissions batch for task: {}, usersPermissions: {}", |
There was a problem hiding this comment.
should be log all permissions on INFO level?
There was a problem hiding this comment.
we will revert everything after debugging is complete
There was a problem hiding this comment.
Don't develop for reverting. Change it to debug and set your log levels at runtime.
|
|
||
| log.info("Assigning permissions batch for task: {}, usersPermissions: {}", | ||
| task, usersPermissions); | ||
| System.out.println("Assigning permissions batch for task: " + task + ", usersPermissions: " + usersPermissions); |
There was a problem hiding this comment.
Why use a system output? It's a super weird solution for logging
There was a problem hiding this comment.
we will revert everything after debugging is complete
There was a problem hiding this comment.
system output is to make sure logs are printed without fail and to save some time
There was a problem hiding this comment.
log.debug will also print when the appropriate level is set in configuration.
|
| public Mono<BatchProductGroupTask> assignPermissionsBatch(BatchProductGroupTask task, | ||
| Map<User, Map<BusinessFunctionGroup, List<BaseProductGroup>>> usersPermissions) { | ||
|
|
||
| log.info("Assigning permissions batch for task: {}, usersPermissions: {}", |
There was a problem hiding this comment.
Don't develop for reverting. Change it to debug and set your log levels at runtime.
|
|
||
| log.info("Assigning permissions batch for task: {}, usersPermissions: {}", | ||
| task, usersPermissions); | ||
| System.out.println("Assigning permissions batch for task: " + task + ", usersPermissions: " + usersPermissions); |
There was a problem hiding this comment.
log.debug will also print when the appropriate level is set in configuration.
| .collect(Collectors.toList()))) | ||
| .collect(Collectors.toList()); | ||
| log.info("Assigned permissions request: {}", request); | ||
| System.out.println("Assigned permissions request: " + request); |
|
Closing the PR as the issue is Resolved . |
Description
A few sentences describing the overall goals of the pull request's commits.
Checklist