Skip to content

fix: Call access-control batchUpdateDataItems with external dataItemsIds #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sasha-ishchuk merged 4 commits into from
Dec 19, 2025
Merged

fix: Call access-control batchUpdateDataItems with external dataItemsIds #572

sasha-ishchuk merged 4 commits into from
Dec 19, 2025

Conversation

@sasha-ishchuk
Copy link
Contributor

@sasha-ishchuk sasha-ishchuk commented Dec 18, 2025 •
edited
Loading

Description

Fix call to access-control batchUpdateDataItems to use external dataItemsIds instead of internal

Checklist

  • I made sure, I read CONTRIBUTING.md to put right branch prefix as per my need.
  • I made sure to update CHANGELOG.md.
  • I made sure to update Stream Wiki(only valid in case of new stream module or architecture changes).
  • My changes are adequately tested.
  • I made sure all the SonarCloud Quality Gate are passed.

@sasha-ishchuk sasha-ishchuk requested a review from a team as a code owner December 18, 2025 08:05
karaelf33
karaelf33 reviewed Dec 18, 2025
View reviewed changes
Copy link

@karaelf33 karaelf33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job 💯

@sasha-ishchuk sasha-ishchuk force-pushed the ac-fix-update-data-items branch from 24ddb33 to dd540f1 Compare December 18, 2025 11:06
@sasha-ishchuk sasha-ishchuk force-pushed the ac-fix-update-data-items branch from dd540f1 to 0de7b63 Compare December 18, 2025 15:11
@sasha-ishchuk sasha-ishchuk force-pushed the ac-fix-update-data-items branch 2 times, most recently from eac66fe to fef27d6 Compare December 18, 2025 21:11
mitrev
mitrev approved these changes Dec 19, 2025
View reviewed changes
@sasha-ishchuk sasha-ishchuk force-pushed the ac-fix-update-data-items branch from fef27d6 to 39a489b Compare December 19, 2025 09:01
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 19, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

eltntawy
eltntawy requested changes Dec 19, 2025
View reviewed changes
Copy link
Contributor

@eltntawy eltntawy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please mark all checklist as done, and make sure this new code is tested.

@sasha-ishchuk sasha-ishchuk merged commit 6c6a7bd into master Dec 19, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eltntawy eltntawy eltntawy approved these changes

@mitrev mitrev mitrev approved these changes

@karaelf33 karaelf33 Awaiting requested review from karaelf33

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sasha-ishchuk @eltntawy @mitrev @karaelf33