Quality Fixes #2
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR improves the overall quality of the application by enhancing testing, adding Playwright end‐to‐end tests, and refactoring account creation logic. Key changes include updating transaction formatting in the UI, migrating database functions to dedicated service modules, and updating API endpoints and test suites to handle errors and validations better.
Reviewed Changes
Copilot reviewed 33 out of 38 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/TransactionsCard.tsx | Updated currency formatting using a helper function |
| scripts/build-schemas.js | Modified generator block injection for Prisma client output |
| playwright.config.ts | Added a new Playwright configuration file with updated settings |
| pages/view/[viewid].tsx & pages/manage/[userid].tsx | Updated backend service calls for fetching and updating account info |
| pages/api/* | Refactored API endpoints to work with service modules and handle errors consistently |
| pages/index.tsx | Enhanced homepage layout with a new description card and image |
| tests/CreateAccountForm.test.tsx | Updated tests to match changes in the CreateAccountForm component |
| CONTRIBUTING.md, .github/workflows/ci.yml, .eslintrc.js | Updated documentation and configuration for style/CI improvements |
Files not reviewed (5)
- .eslintignore: Language not supported
- .prettierignore: Language not supported
- package.json: Language not supported
- prisma/schema.prisma: Language not supported
- scripts/test-all.sh: Language not supported
Comments suppressed due to low confidence (1)
scripts/build-schemas.js:38
- Ensure that the injected indentation and line breaks in the generator block match the existing schema formatting. Misaligned formatting could potentially lead to issues with the Prisma generator block parsing.
const indentedOutput = '\n output = "../node_modules/@prisma/client"';
| res.status(409).send('Account already exists.') | ||
| } else { | ||
| res.status(500).send(`Error - ${error.message}`) | ||
| const { username, password } = req.body |
There was a problem hiding this comment.
The API no longer verifies that the password confirmation matches the provided password. Consider adding a check to ensure that both password fields (e.g., pass and pass2, or a new confirmation field) match before proceeding.
There was a problem hiding this comment.
This is intended behavior. Needs verification on UI side only.
Improve testing, add playwright, fix issue with account creation.