Exp be gone #67
Merged
Exp be gone #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Does not use ExpBeGone trick. * Metropolis works but NUTS not yet.
Clean up BC-normalization code. Clean up dev/num_analysis for bc variables
MaartenMarsman
force-pushed
the
ExpBeGone
branch
from
f524dbf to
898622b
Compare
Bug fix to bgmCompare for BC variables
vandenman
reviewed
Dec 9, 2025
Collaborator
vandenman
left a comment
vandenman
left a comment
There was a problem hiding this comment.
The changes look fine, is there a particular way I should test that this doesn't break anything? Do we have already have a dataset that is numerically challenging?
Collaborator
Author
|
I tested with the Wenchuan dataset. This dataset was a challenge for the Blume-Capel model. It should work well now. I don’t know another challenging one.
From: Don van den Bergh ***@***.***>
Date: Tuesday, 9 December 2025 at 15:33
To: Bayesian-Graphical-Modelling-Lab/bgms ***@***.***>
Cc: Maarten Marsman ***@***.***>, Author ***@***.***>
Subject: Re: [Bayesian-Graphical-Modelling-Lab/bgms] Exp be gone (PR #67)
@vandenman commented on this pull request.
The changes look fine, is there a particular way I should test that this doesn't break anything? Do we have already have a dataset that is numerically challenging?
—
Reply to this email directly, view it on GitHub<#67 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMT3LMYF4GGTVF7P5B7UF6D4A3MT7AVCNFSM6AAAAACJANA6E6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKNJXG44DCNRZGI>.
You are receiving this because you authored the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimizes function calls to exp() in bgm() for regular variables.