feat(files): Add Fullbright pack #680
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new Fullbright resource pack to the Utility category, which increases brightness everywhere to make it appear like daytime even in caves and low-light areas. The pack includes a warning that it only works when Vibrant Visuals graphics mode is enabled.
- Adds Fullbright pack entry to the packs.json configuration with appropriate metadata and warning message
- Implements lighting configuration files for all biome types and dimensions to achieve the fullbright effect
- Includes a pack icon for the resource pack
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| resource_packs/packs.json | Adds Fullbright pack configuration entry with warning about Vibrant Visuals requirement |
| resource_packs/files/utility/fullbright/pack_icon.png | Adds pack icon image for the Fullbright pack |
| resource_packs/files/utility/fullbright/lighting/*.json | Implements lighting settings for various biomes and dimensions to achieve fullbright effect |
resource_packs/files/utility/fullbright/lighting/pale_garden_lighting.json
Outdated
Show resolved
Hide resolved
resource_packs/files/utility/fullbright/lighting/ice_plains_spikes_lighting.json
Outdated
Show resolved
Hide resolved
PAPISOP
force-pushed
the
feat/fullbright
branch
2 times, most recently
from
17236c5 to
ff1c672
Compare
|
Approved but no merge yet Want to check in depth what would happen with pbr cababilities and all packs in general before doing anything pbr |
|
Might need to update some files to match vanilla |
This one requires it, yeah testing it is a good idea |
PAPISOP
force-pushed
the
feat/fullbright
branch
from
ff1c672 to
75b81b4
Compare
Is up to date so good to merge |
PAPISOP
added
enhancement
1. Fullbright pack is added to the Utility category 2. It will ONLY work when Vibrant Visuals is turned on and there is a warning in the website at below the description of the pack Vibrant Visuals has been made the default graphics mode for all the compatible devices and Mojang themselves is recommending to use Vibrant Visuals so, I think it is not a bad idea that it only works when Vibrant Visuals is turned on 3. In order for Fullbright to work in game, @drav0011 needs to update the manifest to include "pbr" capability (Refer to the [messages](<https://discord.com/channels/567364180857061437/1254830627807826092/1389545024613515315>) held at our [discord server](<https://discord.gg/a22vR8vN>))
1. Update Fullbright to match internal vanilla files of Minecraft which are updated in 1.21.120
PAPISOP
force-pushed
the
feat/fullbright
branch
from
a92aced to
5e08ad8
Compare
2 participants
Vibrant Visuals has been made the default graphics mode for all the compatible devices and Mojang themselves is recommending to use Vibrant Visuals so, I think it is not a bad idea that it only works when Vibrant Visuals is turned on
Resolves #661
By checking the following boxes with an X, you ensure that:
The pack was tested ingame in at least one device.
The pack is an existing BT pack, is a missing pack from VT or is an accepted pack/change in a discussion.
The pack code follows the style guide.
The commits follow the contribution guidelines.
The PR follows the contribution guidelines.
(Optional) Tested in Windows
(Optional) Tested in Android
(Optional) Tested in iOS
(Optional) Tested in any console
(Optional) Tested in BDS