-
Notifications
You must be signed in to change notification settings - Fork 60
fix: update max songs per page for qqmusic #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
janzhen
wants to merge
1
commit into
Bistutu:main
Choose a base branch
from
janzhen:fix/max-songs-per-page
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideReduces the maximum number of QQ Music songs returned per page from 1000 to 30 to align with expected pagination limits and avoid over-fetching. Class diagram for QQ Music pagination constants updateclassDiagram
class QQMusicPaginationConfig {
<<constant_group>>
int qqMusicErrorResponseLength
int maxSongsPerPage
int maxTotalSongs
}
QQMusicPaginationConfig : qqMusicErrorResponseLength = 108
QQMusicPaginationConfig : maxSongsPerPage = 30
QQMusicPaginationConfig : maxTotalSongs = 10000
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- Consider adding context in the comment (e.g., link or reference to QQMusic API behavior) explaining why the max is 30 so future changes to the API can be validated against this assumption.
- If other parts of the logic implicitly assume larger page sizes, it may be cleaner to centralize pagination behavior so that changes to maxSongsPerPage do not require scattered adjustments in the future.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider adding context in the comment (e.g., link or reference to QQMusic API behavior) explaining why the max is 30 so future changes to the API can be validated against this assumption.
- If other parts of the logic implicitly assume larger page sizes, it may be cleaner to centralize pagination behavior so that changes to maxSongsPerPage do not require scattered adjustments in the future.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #35
Summary by Sourcery
Bug Fixes: