Skip to content

Conversation

@janzhen
Copy link

@janzhen janzhen commented Jan 13, 2026

fix #35

Summary by Sourcery

Bug Fixes:

  • Reduce qqmusic maximum songs per page from 1000 to 30 to comply with platform pagination constraints.

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 13, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Reduces the maximum number of QQ Music songs returned per page from 1000 to 30 to align with expected pagination limits and avoid over-fetching.

Class diagram for QQ Music pagination constants update

classDiagram
  class QQMusicPaginationConfig {
    <<constant_group>>
    int qqMusicErrorResponseLength
    int maxSongsPerPage
    int maxTotalSongs
  }

  QQMusicPaginationConfig : qqMusicErrorResponseLength = 108
  QQMusicPaginationConfig : maxSongsPerPage = 30
  QQMusicPaginationConfig : maxTotalSongs = 10000
Loading

File-Level Changes

Change Details Files
Adjust QQ Music pagination limit to a smaller, safer page size.
  • Change the max songs per page constant value from 1000 to 30 for QQ Music pagination.
  • Keep overall maximum supported total songs unchanged at 10000.
logic/qqmusic.go

Assessment against linked issues

Issue Objective Addressed Explanation
#35 Ensure QQ音乐 playlist parsing retrieves all songs from a playlist (beyond just the first 30) by correctly handling pagination.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider adding context in the comment (e.g., link or reference to QQMusic API behavior) explaining why the max is 30 so future changes to the API can be validated against this assumption.
  • If other parts of the logic implicitly assume larger page sizes, it may be cleaner to centralize pagination behavior so that changes to maxSongsPerPage do not require scattered adjustments in the future.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider adding context in the comment (e.g., link or reference to QQMusic API behavior) explaining why the max is 30 so future changes to the API can be validated against this assumption.
- If other parts of the logic implicitly assume larger page sizes, it may be cleaner to centralize pagination behavior so that changes to maxSongsPerPage do not require scattered adjustments in the future.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

QQ音乐只解析了首页30首歌,解析不完整

1 participant