maintenance: expose Info method. #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benma
requested changes
Sep 18, 2025
api/firmware/device.go
Outdated
|
|
||
| // Info exposes the underlying info call, given a Communication. | ||
| func Info(communication Communication) (*semver.SemVer, common.Product, bool, error) { | ||
| device := NewDevice(nil, nil, nil, communication, nil) |
Contributor
There was a problem hiding this comment.
Wouldn't it be better to move the impl of info() here, and call Info(device.communication) inside device.info()? calling NewDevice() is overkill, and could lead to bad effects if we change what NewDevice does in the future (e.g. like the idea we discussed to have it call inferVersionAndProduct() right away, which would not be good here :P)
Collaborator
Author
There was a problem hiding this comment.
Much better idea, done :)
benma
requested changes
Sep 18, 2025
api/firmware/device.go
Outdated
Comment on lines
228
to
229
| // info uses the opInfo api endpoint to learn about the version, platform/edition, and unlock | ||
| // status (true if unlocked). |
Contributor
There was a problem hiding this comment.
move this docstring to Info(), the other docstring is not out of date.
This way, the Bitbox backend, when running in simulator mode, can query for the simulated device's version and product.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, the Bitbox backend, when running in simulator mode, can query for the simulated device's version and product.