Skip to content

Work on nearby characters for map nodes, #1629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
tchalvak wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Work on nearby characters for map nodes, #1629

tchalvak wants to merge 2 commits into from

Conversation

@tchalvak
Copy link
Member

@tchalvak tchalvak commented Jan 9, 2024 •
edited
Loading

WIP on creating an api endpoint to call/request characters that are nearby in score, and then place it in an area in the map node.
The nearby by score is obviously just a placeholder proxy for now, and will then be able to be replaced by
nearby in terms of map position moved to.

Purpose of PR:

Before

After

For Non-Hotfixes:

Attached Screenshot of my change:

Things that make review take longer:

(remove lines that do not apply to this PR)

  • Changing more than 20 files (much harder to review)
  • Changing more than 5 files (a bit harder to review)
  • Changes to critical code (login, dashboard, etc)
  • No comments on changed files
  • Tests do not pass (will get pushed back)

Things that make review faster and easier:

(check box with an x where it applies)

  • I attached a screenshot of the changed part of the app working
  • I added tests
  • This feature is requested specifically by a user
  • This will fix a bug

Preview results in my branch at the url:

tchalvak and others added 2 commits March 13, 2022 17:02
@tchalvak
Work on nearby characters for map nodes,
8fa399d 
WIP.
@deepsource-autofix
style: format code with PHP CS Fixer
bcc34db 
This commit fixes the style issues introduced in 8fa399d according to the output
from PHP CS Fixer.

Details: #1629
@tchalvak tchalvak marked this pull request as draft February 11, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Feature Request needs work wip

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tchalvak