Skip to content

Conversation

@tchalvak
Copy link
Member

Purpose of PR:

Before

After

For Non-Hotfixes:

Attached Screenshot of my change:

Things that make review take longer:

(remove lines that do not apply to this PR)

  • Changing more than 20 files (much harder to review)
  • Changing more than 5 files (a bit harder to review)
  • Changes to critical code (login, dashboard, etc)
  • No comments on changed files
  • Tests do not pass (will get pushed back)

Things that make review faster and easier:

(check box with an x where it applies)

  • I attached a screenshot of the changed part of the app working
  • I added tests
  • This feature is requested specifically by a user
  • This will fix a bug

Preview results in my branch at the url:

@tchalvak tchalvak added the hold label May 31, 2024
@tchalvak
Copy link
Member Author

Awaiting other commit changes.

@cypress
Copy link

cypress bot commented May 31, 2024

NinjaWars Functional Testing    Run #709

Run Properties:  status check failed Failed #709  •  git commit 26a2e27bd8 ℹ️: Merge 9f94d105f3f88f373cacbd4b7c3fa37d95c18bd0 into 74853e1450518346320c9de72ac5...
Project NinjaWars Functional Testing
Branch Review feat/changes-76
Run status status check failed Failed #709
Run duration 01m 46s
Commit git commit 26a2e27bd8 ℹ️: Merge 9f94d105f3f88f373cacbd4b7c3fa37d95c18bd0 into 74853e1450518346320c9de72ac5...
Committer Coco R
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 13
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/fight.cy.js • 1 failed test

View Output

Test Artifacts
fight > can attack a thief Test Replay Screenshots

@tchalvak tchalvak changed the title Fix for catchphrases.size() that no longer exists. jQuery 3 updates, fix to avoid deprecated catchphrases.size() May 31, 2024
@tchalvak tchalvak marked this pull request as draft June 1, 2024 22:19
@tchalvak
Copy link
Member Author

tchalvak commented Jun 1, 2024

Check on the functionality of the enemies page and dishing and bath house, etc.

@tchalvak tchalvak self-assigned this Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants