Skip to content

Conversation

@oroderico
Copy link
Contributor

Root Cause

On Waveshare ESP32-S3 LCD Touch (portrait), the Home screen header has less
horizontal space than landscape boards. The default title uses the full
device_name string (e.g. Jade <short-id>), which can be clipped on the
portrait header.

The device identifier itself is correct; only the rendering is affected.

Fix

For Waveshare S3 only (CONFIG_BOARD_TYPE_WS_TOUCH_LCD2), adjust the Home
screen activity title:

  • When the device name matches the expected Jade prefix, the UI uses only
    the suffix portion (skipping the Jade prefix) as the title.
  • This reduces the title width in portrait mode and avoids truncation.

Implementation Notes

  • Minimal, localized change: only affects the Home screen title argument passed
    to gui_make_activity_ex().
  • No changes to ID generation, session/scan logic, or other boards.

@jgriffiths
Copy link
Collaborator

Hi, I think the problem of titles being too wide for screens in given orientations should be considered a generic one, and so fixed generically rather than on a per-screen and/or per-device basis, even if this needs to be opted into with a flag.

@oroderico
Copy link
Contributor Author

I can fix this, but I did it this way because I didn't have other boards to test the behavior of the fix. Can I adjust the code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants