-
Notifications
You must be signed in to change notification settings - Fork 157
Added db metric reporting and config options. #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds database metric reporting capabilities and configuration options for RocksDB performance tuning. The changes enable monitoring of RocksDB internals through Prometheus metrics and provide configurable parameters for memory usage and parallelism.
- Added comprehensive RocksDB metrics collection for memory tables, compactions, and cache usage
- Introduced configuration options for block cache size, parallelism, and write buffer size
- Integrated metrics exporter with background thread to periodically update gauges
Reviewed Changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/new_index/db_metrics.rs | New module defining RocksDB metrics structure with comprehensive gauge collections |
| src/new_index/db.rs | Enhanced DB struct with metrics export functionality and configurable RocksDB options |
| src/new_index/schema.rs | Updated Store constructor to accept metrics and initialize DB stats exporters |
| src/new_index/mod.rs | Added db_metrics module export |
| src/config.rs | Added command-line arguments and config fields for RocksDB tuning parameters |
| tests/common.rs | Updated test configuration with new DB parameter defaults |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
291dde2 to
aadd1e3
Compare
|
I amended the commit with copilot's suggestions |
56e68b6 to
9364d54
Compare
9364d54 to
5eb8221
Compare
5eb8221 to
027e38d
Compare
RCasatta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 027e38d
No description provided.