Skip to content

Conversation

@Randy808
Copy link

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds database metric reporting capabilities and configuration options for RocksDB performance tuning. The changes enable monitoring of RocksDB internals through Prometheus metrics and provide configurable parameters for memory usage and parallelism.

  • Added comprehensive RocksDB metrics collection for memory tables, compactions, and cache usage
  • Introduced configuration options for block cache size, parallelism, and write buffer size
  • Integrated metrics exporter with background thread to periodically update gauges

Reviewed Changes

Copilot reviewed 6 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/new_index/db_metrics.rs New module defining RocksDB metrics structure with comprehensive gauge collections
src/new_index/db.rs Enhanced DB struct with metrics export functionality and configurable RocksDB options
src/new_index/schema.rs Updated Store constructor to accept metrics and initialize DB stats exporters
src/new_index/mod.rs Added db_metrics module export
src/config.rs Added command-line arguments and config fields for RocksDB tuning parameters
tests/common.rs Updated test configuration with new DB parameter defaults

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Randy808
Copy link
Author

I amended the commit with copilot's suggestions

@Randy808 Randy808 force-pushed the add-db-metrics branch 2 times, most recently from 56e68b6 to 9364d54 Compare September 16, 2025 15:20
@Randy808 Randy808 marked this pull request as ready for review September 17, 2025 17:19
Copy link
Collaborator

@RCasatta RCasatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 027e38d

@RCasatta RCasatta merged commit 027e38d into Blockstream:new-index Sep 22, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants