-
Notifications
You must be signed in to change notification settings - Fork 492
feat(prerenderer): improving under high load #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the prerender server's performance under high load by implementing proper queuing mechanisms and better resource management. The changes address potential bottlenecks when the server receives more requests than it can handle efficiently.
- Adds express-queue dependency for request queuing with configurable limits
- Implements better IPC-based communication for cluster mode rendering coordination
- Refactors middleware structure to separate cookie handling from rendering logic
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| prerender-server/src/server.js | Implements request queuing, refactors middleware structure, and improves cluster communication |
| prerender-server/src/cluster.js | Updates default MAX_TOTAL_RENDERS to use numCPUs instead of hardcoded value |
| prerender-server/package.json | Adds express-queue dependency for request management |
Files not reviewed (1)
- prerender-server/npm-shrinkwrap.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
fe40f72 to
9529d4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- prerender-server/npm-shrinkwrap.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.