Skip to content

Conversation

@JohnThomson
Copy link
Contributor

@JohnThomson JohnThomson commented Jan 20, 2026

This change is Reviewable

Copy link
Contributor

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrew-polk reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @JohnThomson).


src/BloomExe/web/controllers/CollectionApi.cs line 704 at r1 (raw file):

            if (
                Path.GetFileName(fullImagePath) == "placeHolder.png"

Can use ImageUtils.IsPlaceholderImageFilename

Copy link
Contributor Author

@JohnThomson JohnThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JohnThomson made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrew-polk).


src/BloomExe/web/controllers/CollectionApi.cs line 704 at r1 (raw file):

Previously, andrew-polk wrote…

Can use ImageUtils.IsPlaceholderImageFilename

Done.

Copy link
Contributor

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but awaiting JH's thoughts on the overall approach.

@andrew-polk reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @JohnThomson).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants