Avoid locale sensitive std::stof function #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incredibleLeitman
added a commit
to incredibleLeitman/OBJ-Loader
that referenced
this pull request
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::stof function's decimal separator is defined in locale (in LC_NUMERIC), and it may vary depending on chosen locale, which leads to loss of fraction in all floating-point numbers when using different locale (i.e in russian comma is used instead of a dot). I made li_stof function that is independent from locale. It always uses dot as a decimal separator, and does not change the locale.
Also added some minor fixes, maybe fixing #22.