Skip to content

Fixed small warnings for VS2017 compiler #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VladimirBalun wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed small warnings for VS2017 compiler #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Source/OBJ_Loader.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,7 @@ namespace objl

if (temp.size() != 1)
{
for (int i = 0; i < temp.size() - 1; i++)
for (size_t i = 0; i < temp.size() - 1; i++)
{
pathtomat += temp[i] + "/";
}
Expand Down Expand Up @@ -686,13 +686,13 @@ namespace objl
file.close();

// Set Materials for each Mesh
for (int i = 0; i < MeshMatNames.size(); i++)
for (size_t i = 0; i < MeshMatNames.size(); i++)
{
std::string matname = MeshMatNames[i];

// Find corresponding material name in loaded materials
// when found copy material variables into mesh material
for (int j = 0; j < LoadedMaterials.size(); j++)
for (size_t j = 0; j < LoadedMaterials.size(); j++)
{
if (LoadedMaterials[j].name == matname)
{
Expand Down Expand Up @@ -946,7 +946,7 @@ namespace objl
}

// If Vertex is not an interior vertex
float angle = math::AngleBetweenV3(pPrev.Position - pCur.Position, pNext.Position - pCur.Position) * (180 / 3.14159265359);
float angle = static_cast<float>(math::AngleBetweenV3(pPrev.Position - pCur.Position, pNext.Position - pCur.Position) * (180 / 3.14159265359));
if (angle <= 0 && angle >= 180)
continue;

Expand Down