added rates_table.public_notes
#238
Conversation
Azdaroth
left a comment
Azdaroth
left a comment
There was a problem hiding this comment.
@LeonidMorozov Can you update the changelog please?
StoneFrog
left a comment
StoneFrog
left a comment
There was a problem hiding this comment.
Also response needs updating
| id | Integer | Read | Rates Table's id. | ||
| -----------------|---------|------------------------- | ||
| name | String | Read/Write | **Required**. Rates Table's name. (50 characters max) | ||
| public_notes | Text | Read | Rates Table's public notes. |
There was a problem hiding this comment.
I think we should use JSON types only, right? So String rather than Text
There was a problem hiding this comment.
@StoneFrog , I see Type = Text on other entities as well. Are you sure we should use String ?
There was a problem hiding this comment.
I'd keep text, it's obvious that text is longer than string, but we can add a section about what our types mean in the doc if you think this needs clarification.
There was a problem hiding this comment.
"String" would be more correct, but I think "Text" is more practical, same as Integer vs. Biginteger.
There was a problem hiding this comment.
I'm ok with keeping text but good to explain it. We already have formats section explaining time, decimal and so on.
|
@Azdaroth please dismiss your review, point about changelog is not valid anymore 😉 |
No description provided.