Skip to content

Conversation

@BryanSJamesDev
Copy link

In the updated code, I added a select element with the id themeSelector inside the navbar div. This element allows users to select different themes for the calendar. I also included a JavaScript snippet at the end of the code to handle the theme change event. When the user selects a different theme, the change event listener updates the className of the calendar element based on the selected theme. This will apply the corresponding CSS styles defined in your style.css file to change the appearance of the calendar based on the selected theme.

@BoolPurist
Copy link
Owner

Cool idea for an addition. However I do not want to pull your purposed change yet for a few problems in my view.


I see 2 problems here.

  • None of the themes changes the color of the website at all.
  • Changes to the index html file caused the disappearing of the section, calander week, and changed the layout of website even in the "default" theme.

I propose the following additions to your pull request to improve your changes.

  • Changes to style.css.
    These changes should provide the styling for the 2 other themes "light" and "dark". This styling should cause the color of the website to change when changing themes.
  • Adjust the changes to html so that the layout with all the information, especially the calendar weeks, is still is preserved.
    It should look like that in the "default" theme:

website

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants