Always chooses the first slideshow in the select. #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin is incompatible with ACF.
When adding a upload field ACF outputs a hidden dummy editor at the bottom of the edit page for a post (I do not know why).
The line here looks for an element with ID
insertSlideshowShortcodeSlideshowSelect. But because ACF outputs the dummy editor we end up with two elements with the same ID. The modal (a.k.a. ThickBox) always ends up at the end of the document, meaning that the code always selects the value of the select box in the dummy editor. I hope you can follow :)Changing the line to something more contextual like:
slideshowID = parseInt($(event.target).closest('table').find('select').val(), 10),would make this plugin work again properly. This guards against any duplicates created by other plugins and assures that the modal will always use the value of the select next to the insert-button.