using inline <reified T> to convert querySnapShot to List<T>

data/src/main/java/com/wiseassblog/data/DataExt.kt

@@ -2,12 +2,14 @@ package com.wiseassblog.data
 
 import android.net.Uri
 import com.google.android.gms.tasks.Task
+import com.google.firebase.firestore.QuerySnapshot
 import com.wiseassblog.data.datamodels.AnonymousRoomNote
 import com.wiseassblog.data.datamodels.RegisteredRoomNote
 import com.wiseassblog.data.datamodels.RegisteredRoomTransaction
 import com.wiseassblog.data.datamodels.FirebaseNote
 import com.wiseassblog.domain.domainmodel.Note
 import com.wiseassblog.domain.domainmodel.NoteTransaction
+import com.wiseassblog.domain.domainmodel.Result
 import com.wiseassblog.domain.domainmodel.TransactionType
 import com.wiseassblog.domain.domainmodel.User
 import kotlin.coroutines.resume
@@ -24,6 +26,7 @@ suspend fun <T> awaitTaskResult(task: Task<T>): T = suspendCoroutine { continuat
         }
     }
 }
+
 //Wraps Firebase/GMS calls
 suspend fun <T> awaitTaskCompletable(task: Task<T>): Unit = suspendCoroutine { continuation ->
     task.addOnCompleteListener { task ->
@@ -150,3 +153,14 @@ internal fun List<RegisteredRoomNote>.toNoteListFromRegistered(): List<Note> = t
 internal fun List<RegisteredRoomTransaction>.toNoteTransactionListFromRegistered(): List<NoteTransaction> = this.flatMap {
     listOf(it.toTransaction)
 }
+
+
+internal inline fun <reified T> resultToList(result: QuerySnapshot?): Result<Exception, List<T>> {
+    val targetList = mutableListOf<T>()
+    result?.forEach { documentSnapshop ->
+        targetList.add(documentSnapshop.toObject(T::class.java))
+    }
+    return Result.build {
+        targetList
+    }
+}

data/src/main/java/com/wiseassblog/data/note/public/FirestorePublicNoteRepositoryImpl.kt

@@ -2,8 +2,7 @@ package com.wiseassblog.data.note.public
 
 import com.google.firebase.firestore.FirebaseFirestore
 import com.google.firebase.firestore.QuerySnapshot
-import com.wiseassblog.data.awaitTaskCompletable
-import com.wiseassblog.data.awaitTaskResult
+import com.wiseassblog.data.*
 import com.wiseassblog.data.datamodels.FirebaseNote
 import com.wiseassblog.data.toFirebaseNote
 import com.wiseassblog.data.toNote
@@ -13,6 +12,7 @@ import com.wiseassblog.domain.repository.IPublicNoteRepository
 
 
 const val COLLECTION_PUBLIC = "public_notes"
+
 object FirestoreRemoteNoteImpl : IPublicNoteRepository {
     override suspend fun getNotes(): Result<Exception, List<Note>> {
         val firestore = FirebaseFirestore.getInstance()
@@ -22,7 +22,7 @@ object FirestoreRemoteNoteImpl : IPublicNoteRepository {
         return try {
             val task = awaitTaskResult(reference.get())
 
-            return resultToNoteList(task)
+            return resultToList<Note>(task)
         } catch (exception: Exception) {
             Result.build { throw exception }
         }
@@ -77,15 +77,4 @@ object FirestoreRemoteNoteImpl : IPublicNoteRepository {
         }
     }
 
-    private fun resultToNoteList(result: QuerySnapshot?): Result<Exception, List<Note>> {
-        val noteList = mutableListOf<Note>()
-
-        result?.forEach { documentSnapshop ->
-            noteList.add(documentSnapshop.toObject(FirebaseNote::class.java).toNote)
-        }
-
-        return Result.build {
-            noteList
-        }
-    }
 }

data/src/main/java/com/wiseassblog/data/note/registered/FirestorePrivateRemoteNoteImpl.kt

@@ -2,9 +2,9 @@ package com.wiseassblog.data.note.registered
 
 import com.google.firebase.firestore.FirebaseFirestore
 import com.google.firebase.firestore.QuerySnapshot
-import com.wiseassblog.data.awaitTaskCompletable
-import com.wiseassblog.data.awaitTaskResult
+import com.wiseassblog.data.*
 import com.wiseassblog.data.datamodels.FirebaseNote
+import com.wiseassblog.data.resultToList
 import com.wiseassblog.data.toFirebaseNote
 import com.wiseassblog.data.toNote
 import com.wiseassblog.domain.domainmodel.Note
@@ -28,25 +28,12 @@ class FirestorePrivateRemoteNoteImpl(
         return try {
             val task = awaitTaskResult(reference.get())
 
-            return resultToNoteList(task)
+            return resultToList(task)
         } catch (exception: Exception) {
             Result.build { throw exception }
         }
     }
 
-    private fun resultToNoteList(result: QuerySnapshot?): Result<Exception, List<Note>> {
-        val noteList = mutableListOf<Note>()
-
-        result?.forEach { documentSnapshop ->
-            noteList.add(documentSnapshop.toObject(FirebaseNote::class.java).toNote)
-        }
-
-        return Result.build {
-            noteList
-        }
-    }
-
-
     override suspend fun getNote(id: String): Result<Exception, Note?> {
         var reference = firestore.collection(COLLECTION_NAME)
                 .document(id)

domain/src/main/java/com/wiseassblog/domain/domainmodel/NoteTransaction.kt

@@ -21,4 +21,4 @@ fun Note.toTransaction(type: TransactionType): NoteTransaction = NoteTransaction
         imageUrl,
         creator,
         type
-)
+        )

domain/src/main/java/com/wiseassblog/domain/error/SpaceNotesError.kt

@@ -10,8 +10,6 @@ sealed class SpaceNotesError: Exception() {
     object AuthError: SpaceNotesError()
     object TransactionIOException : SpaceNotesError()
 
-
-
 }
 
 const val ERROR_UPDATE_FAILED = "Update operation unsuccessful."

domain/src/main/java/com/wiseassblog/domain/interactor/PublicNoteSource.kt

@@ -6,6 +6,7 @@ import com.wiseassblog.domain.domainmodel.Result
 
 
 class PublicNoteSource {
+
     suspend fun getNotes(locator: NoteServiceLocator): Result<Exception, List<Note>> = locator
             .remotePublic
             .getNotes()