Skip to content

Feature/bi 2132 a #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
nickpalladino wants to merge 68 commits into
base: feature/BI-2132
Choose a base branch
from
Draft

Feature/bi 2132 a #370

nickpalladino wants to merge 68 commits into from

Conversation

@nickpalladino
Copy link
Member

@nickpalladino nickpalladino commented Jul 3, 2024

Description

Story: Please include a link to the story in Jira

Please include a summary of the change that was made.

Dependencies

Please include any dependencies to other code branches, testing configurations, scripts to be run, etc.

Testing

Please include any details needed for reviewers to test this code

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

rob-ouser-bi and others added 30 commits May 6, 2024 15:33
@rob-ouser-bi
[autocommit] bumping build number
c18b75a
@nickpalladino
Update version.properties
e26da32
@rob-ouser-bi
[autocommit] bumping build number
8a95cda
@mlm483
Merge branch 'bug/BI-2065' into release/0.9.1
ed1fd02
@rob-ouser-bi
[autocommit] bumping build number
86922f2
@davedrp
[BI-2127] return Lat, Long, Elevation, and RTK
e7e46b7
@davedrp
[BI-2127] protect against nulls
1a909b6
@davedrp
[BI-2127] protect against a double beign NaN (not yet set) before con…
5a2100c 
…verting to a string
@mlm483
[BI-2128] implemented fix and integration tests
a52eebd
@mlm483
[BI-2128] added test description
c3af14f
@mlm483
[BI-2128] fixed typo
fa8c7cb
@rob-ouser-bi
[autocommit] bumping build number
aa138b6
@mlm483
Merge branch 'bug/BI-2128' into develop
626d737
@rob-ouser-bi
[autocommit] bumping build number
c67e67a
@davedrp
Merge branch 'develop' into bug/BI-2127
4bcc841
@davedrp
[BI-2127] made code more readable
2e41d4c
@davedrp
Merge pull request #356 from Breeding-Insight/bug/BI-2127
6662651 
BI-2127 Position Information missing from exp download file
@rob-ouser-bi
[autocommit] bumping build number
453cf79
@dmeidlin
create micronaut composite pattern classes for experiment import work…
5564ca1 
…flow
@dmeidlin
create FileImportService method for GET workflows
f726611
@dmeidlin
delete unused classes
f6952dd
@dmeidlin
clean up and renaming
5e31aa6
@dmeidlin
add overrides to import services
708793d
@dmeidlin
create ExperimentWorkflow interface that extends Workflow interface
68bdacb
@dmeidlin
create interfaces for germplasm and sample workflows
0e022f1
@dmeidlin
create interfaces
f2a1034
@davedrp
[BI-2127] merged with BI-2127 into release/0.9.1
1d63a71
@rob-ouser-bi
[autocommit] bumping build number
8a28a2d
@dmeidlin
restore germplasmAccessionNumber to GermplasmTemplateMap
9104a3e
@dmeidlin
Merge pull request #363 from Breeding-Insight/bug/BI-2155
4e51c9f 
[BI-2155] Cannot create a new list referencing existing GIDs
dmeidlin and others added 30 commits June 10, 2024 17:43
@dmeidlin
fix npe
57f5cfb
@dmeidlin
Merge pull request #360 from Breeding-Insight/feature/BI-2122-A
d21a988 
[BI-2122-A] Workflows Select
@nickpalladino
Merge branch 'feature/BI-2122' into feature/BI-2132-A
e406e38
@nickpalladino
Messing with dependency issue
79189ba
@nickpalladino
Removed ununsed fileImportService injection and resolved DI issue
0ef8cd5
@nickpalladino
Added in BI-2128 change
1acd04b
@nickpalladino
Merge branch 'develop' into feature/BI-2132-A
fc2a661
@nickpalladino
Updated create only tests to use create workflow
6a4043d
@nickpalladino
Removed unused migration
651cffc
@nickpalladino
Removed append environment workflow
39fb8cd
@nickpalladino
Fix error message
be8ea38
@nickpalladino
Removed navigator stuff handled in domain import service
d11ef3c
@nickpalladino
Removed some development comments
eebb493
@nickpalladino
Added db migration to change UNK breeding method class to Increase
1225ab4
@nickpalladino
Removed trailing whitespace on Unknown breeding method
d30d04f
@nickpalladino
Reference enum for new-experiment
b5dc3e8
@nickpalladino @mlm483
Change variable name to reflect string type
2bbf7f3 
Co-authored-by: mlm483 <128052931+mlm483@users.noreply.github.com>
@nickpalladino
Clarified comment
ccc1414
@nickpalladino
Clarified comment
7a35165
@nickpalladino
Removed old comment
aa06c6e
@nickpalladino
Updated doc comment
dd6f348
@nickpalladino
Cleaned up ProcessedData code
a6c3590
@nickpalladino
Changed from workflow to workflowId
1a6de32
@nickpalladino
Merge pull request #369 from Breeding-Insight/bug/BI-1975
4e9e1b8 
BI-1975 - "Unknown" Breeding Method not recognized
@rob-ouser-bi
[autocommit] bumping build number
281cc6c
@nickpalladino
Swapped lat and lon as they were reversed
28a2272
@nickpalladino
Merge pull request #368 from Breeding-Insight/bug/BI-2167
a960d55 
BI-2167 - Lat and long values are getting swapped in the exp download file
@rob-ouser-bi
[autocommit] bumping build number
48a8817
@nickpalladino
Change exception handling
a488612
@nickpalladino
Merge branch 'develop' into feature/BI-2132-A
9b04d44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nickpalladino @rob-ouser-bi @mlm483 @davedrp @dmeidlin