Add @Accessor and @Invoker mixin support #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement support for Mixin @Accessor annotations, allowing mods to generate getter/setter methods for private instance fields on target classes. Key changes: - Add SyntheticClassRegistry to manage Mixin-generated accessor classes - Update BytecodeProvider to handle synthetic class generation - Update ClassProvider to load synthetic classes at runtime - Update LaunchEnvironment with helper for runtime class loading Limitation: Static accessor methods are not supported due to Java requiring method bodies in interface static methods, which conflicts with Mixin's SubType classification system.
logan-mcduffie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@Accessorand@Invokerannotations@Accessorenables mods to generate getter/setter methods for private instance fields@Invokerenables mods to call private methods on target classesSyntheticClassRegistryto manage Mixin-generated synthetic classes that don't exist on diskBytecodeProviderandClassProviderto handle synthetic class generation and loadingTechnical Details
Accessor and invoker mixins work by generating synthetic classes at runtime. Since Hytale's
TransformingClassLoaderonly transforms classes that exist on disk, this PR adds infrastructure to:Known Limitation: Static accessor methods are not supported due to Java requiring method bodies in interface static methods, which conflicts with Mixin's SubType classification system. This is a minor limitation since static fields typically have public getters.