Skip to content

Conversation

@JieXiong9119
Copy link
Contributor

Any background context you want to provide?

What does this PR do?

Update examples to referencing BuildingSync 2.7

How should this be manually tested?

What are the relevant tickets?

Screenshots (if appropriate)

@JieXiong9119 JieXiong9119 self-assigned this Sep 11, 2025
@JieXiong9119 JieXiong9119 added Non-breaking Change Schema: No Changes No updates to the BuildingSync Schema labels Sep 11, 2025
Copy link
Contributor

@ThibaultMarzullo ThibaultMarzullo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last year, we updated pyproject.toml, see this diff. We should update it this year too. In a future PR, I think that you should include yourself as a schema author in that file, considering that you were the main developer over several years.

@JieXiong9119
Copy link
Contributor Author

Last year, we updated pyproject.toml, see this diff. We should update it this year too. In a future PR, I think that you should include yourself as a schema author in that file, considering that you were the main developer over several years.

Good catch. I didn't notice Nicholas changes the file path and thought it was removed (but it's in the root directory now).
I think the authors here are contributors to the poetry setting, so I won't add my name.

@ThibaultMarzullo ThibaultMarzullo self-requested a review September 16, 2025 15:19
Copy link
Contributor

@ThibaultMarzullo ThibaultMarzullo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jie! Nevermind about the Poetry file then, my bad.

@JieXiong9119 JieXiong9119 merged commit 81ae903 into develop-v2 Sep 16, 2025
5 checks passed
@JieXiong9119 JieXiong9119 deleted the feat/update-examples-to-2.7 branch September 16, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Non-breaking Change Schema: No Changes No updates to the BuildingSync Schema

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants