feat: Add --redact to mask execs that stdout/err secrets #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
mbevc1
reviewed
Oct 23, 2025
| SSORegistrationScopes string `ini:"sso_registration_scopes,omitempty"` | ||
| } | ||
|
|
||
| // AwsVaultSection is an [aws-vault] section of the config file |
There was a problem hiding this comment.
I suggest we minimise introducing changes to AWS config file, and if you could please align it with existing approach used for other options - combo of CLI argument and ENV variable? I think this would avoid adding cutom things, which might affect other parsers.
mbevc1
reviewed
Oct 23, 2025
| BoolVar(&input.UseStdout) | ||
|
|
||
| cmd.Flag("redact", "Redact AWS credentials from subprocess output"). | ||
| BoolVar(&input.RedactSecrets) |
mbevc1
reviewed
Oct 23, 2025
Comment on lines
+253
to
+254
| // When redaction is disabled, try doExecSyscall first for better performance | ||
| err = doExecSyscall(input.Command, input.Args, cmdEnv) // will not return if exec syscall succeeds |
There was a problem hiding this comment.
Could we perhaps leave the existing handling path here for backwards compatibility?
|
Thanks for your contribution, I've left few suggestions and questions. |
mbevc1
changed the title
|
@Lingnik does the feedback make sense? |
|
Hi @Lingnik , are you still working on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like how
op run -- fooredacts secrets it's aware of.Because sometimes you want Claude Code to have access to your AWS account, but not the keys.