Feat/raft transport comp (#180) #238
Conversation
saeid-a
force-pushed
the
feat/raft-transport-comp-#180
branch
from
b4f5d85 to
aa3c3cf
Compare
sjcsjc123
left a comment
sjcsjc123
left a comment
There was a problem hiding this comment.
Thank you for your efficient work. I need to carefully analyze it!
| // and receive rpc from other raft nodes | ||
| type transport struct { | ||
| type Transport struct { | ||
| //implement me |
There was a problem hiding this comment.
Perhaps this comment can be deleted.
|
Can you directly submit the code to the branch of the main project |
|
If all the components of the
Can you share your opinion? |
| func newTransport() raft.Transport { | ||
| return &transport{} | ||
| func newTransport(conf config.Config, l net.Listener, do []grpc.DialOption) (*Transport, error) { | ||
| s := grpc.NewServer() |
There was a problem hiding this comment.
Our current design involves a raft cluster with multiple regions on a store node, so the grpc port of a store node can be shared by the region list. Creating a new grpc server here may not be in line with the design objectives. The ultimate goal we aim to achieve is for the Meta cluster to manage the scheduling and allocation of the store cluster and the region cluster on the store. Among them, the meta cluster serves as a raft cluster to ensure strong consistency. At the same time, the region on the store and the region shards on other stores also form a raft cluster. As a store may contain multiple regions, there will be multiple raft nodes on one store at the same time. This is my design proposal. If you feel that it is not suitable or have any questions, you can share it! For this NewServer, we can create a new grpc server when starting the store and pass it as a parameter to the transport component. Additionally, a grpc server can register multiple work servers.
2 participants
I have completed the initial implementation of the raft transport. Can you review it and let me know if there are any issues or if it looks good? Thank you.