Skip to content

Conversation

@nullablepointer
Copy link
Contributor

  • Add scaling support for mainhand and offhand
  • Add Arm setting for configuring how the hand is rendered without items

Sadly scaling the arm doesn't work using these mixins, though the Z translation offers the "old" scaling. This could be improved if we added a new setting type (for ex Vec3DSetting) that would allow for easy configuration of XYZ values.

Also note that tridents and crossbows have their old scale/translations since otherwise they would look bad (crossbow not centered etc). If someone has an idea how to circumvent this, feel free to edit this.
Maps are rendered using a different method that is not included in this mixin.

@MukjepScarlet MukjepScarlet requested a review from 1zun4 October 12, 2025 12:41
@MukjepScarlet
Copy link
Contributor

We do have vec3d settings.

@MukjepScarlet
Copy link
Contributor

private val renderOffset by vec3d("RenderOffset", Vec3d.ZERO)

@nullablepointer
Copy link
Contributor Author

We do have vec3d settings.

i don't think they allow for min and max settings, which would be needed for this type of setting

@MukjepScarlet
Copy link
Contributor

Current vec3d and vec3i value are designed for position-like stuffs.

@MukjepScarlet
Copy link
Contributor

Arm not working.

@MukjepScarlet MukjepScarlet marked this pull request as draft October 18, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants