improve(CI): Build is faster now #7549
Open
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
by default workflow only allowed to save cache from master/main, so I have change it a bit |
kroune
commented
Jan 5, 2026
| distribution: 'graalvm' | ||
| distribution: 'temurin' | ||
| java-version: '21' | ||
| cache: 'gradle' |
Contributor
Author
There was a problem hiding this comment.
this prevented the gradle cache use, setup-java only cached dependencies, but not steps/tasks
kroune
commented
Jan 5, 2026
| uses: actions/setup-java@v4 | ||
| with: | ||
| distribution: 'graalvm' | ||
| distribution: 'temurin' |
Contributor
Author
There was a problem hiding this comment.
it is just faster in general, graalvm is definitely not the fastest one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is hard to measure exact build time improvements, but I would estimate that is is >30s compared to no cache
https://github.com/kroune/LiquidBounce/actions/runs/20696465844/job/59418635868 - 6m 34s build with a small change in code, no cache used
https://github.com/kroune/LiquidBounce/actions/runs/20696270197/job/59418865451 - pipeline runs on master (nextgen) and saves caches which takes ~46s
https://github.com/kroune/LiquidBounce/actions/runs/20696465844/job/59419093121 - 3m 6s build with a small change, cache used from master (nextgen)
cache used from master (nextgen) on a pr, cache isn't stored
cache stored on master (nextgen) (it doesn't use cache because it didn't have any at the time, but after first run there is always cache to use)