Skip to content

Fix out-of-bounds panic in GXF VBI parsing #2069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
THE-Amrit-mahto-05 wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −2
Open

Fix out-of-bounds panic in GXF VBI parsing #2069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/rust/src/es/userdata.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,6 @@ pub unsafe fn user_data(
}
// GXF vbi OEM code
else if ud_header.starts_with(&[0x73, 0x52, 0x21, 0x06]) {
let udatalen = ustream.data.len() - ustream.pos;
ustream.read_bytes(4)?; // skip header code
ustream.read_bytes(2)?; // skip data length
let line_nb = ustream.read_bits(16)? as u16;
Expand All @@ -544,7 +543,7 @@ pub unsafe fn user_data(
info!("MPEG:VBI: only support Luma line");
}

if udatalen < 720 {
if ustream.bits_left < 720 * 8 {
info!("MPEG:VBI: Minimum 720 bytes in luma line required");
return Ok(1);
}
Expand Down
Loading