lyd_validate_minmax(): always return a valid data path if available #2354
+26
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
guess I need to update test cases to look at the 'better' paths returned :) |
bradh352
force-pushed
the
validate-minmax
branch
3 times, most recently
from
66a2dae to
1cc6c49
Compare
bradh352
changed the title
Contributor
Author
|
ok, test cases are passing now. the actual test cases that were failing were due to 'parent' being NULL. Only in those cases does it now return a schema path, since parent would never be NULL if it was a child of a list. |
bradh352
force-pushed
the
validate-minmax
branch
from
1cc6c49 to
230040b
Compare
The current code never returns a data path, only a schema path for failures where the 'min' value is not reached. Integrators may need to obtain both a LIST key as well as the leaf name to present proper error messages. When we don't have a full valid data path, the code now will return the parent's data path with the current schema node name appended. Only if there is no parent (not a realworld issue, but the test system does this) will the schema path be used. This fix was inspired by porting of SONiC's sonic-mgmt-common which is utilizing this feature which previously worked with libyang1. Signed-off-by: Brad House <brad@brad-house.com>
bradh352
force-pushed
the
validate-minmax
branch
from
230040b to
6eb7963
Compare
Member
|
Fixed the path myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code never returns a data path, only a schema path for
failures where the 'min' value is not reached. Integrators may need
to obtain both a LIST key as well as the leaf name to present proper
error messages.
When we don't have a full valid data path, the code now will return
the parent's data path with the current schema node name appended.
Only if there is no parent (not a realworld issue, but the test
system does this) will the schema path be used.
This fix was inspired by porting of SONiC's sonic-mgmt-common which
is utilizing this feature which previously worked with libyang1.
Fixes #2353