validate: unions with leafrefs may return misleading error codes #2360
+67
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a leafref is not found in a union, it should not return an error indicating the value for the leafref wouldn't match the restrictions for a target but instead just say the leafref target wasn't found. The only data that should indicate the error message for data type restrictions is data associated with the target itself, not leafrefs. Signed-off-by: Brad House <brad@brad-house.com>
This was referenced Feb 28, 2025
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 1, 2025
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 1, 2025
michalvasko
requested changes
Mar 3, 2025
Member
michalvasko
left a comment
michalvasko
left a comment
There was a problem hiding this comment.
Fine, after fixing the issues this can be merged.
michalvasko
requested changes
Mar 3, 2025
bradh352
force-pushed
the
bradh352/union_leafref_error
branch
from
3d6c33a to
e3cd01a
Compare
michalvasko
approved these changes
Mar 3, 2025
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 3, 2025
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 4, 2025
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 5, 2025
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 5, 2025
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 6, 2025
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 8, 2025
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 11, 2025
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 12, 2025
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Apr 3, 2025
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Apr 3, 2025
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Apr 20, 2025
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Apr 22, 2025
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Apr 23, 2025
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Apr 24, 2025
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a leafref is not found in a union, it should not return an error indicating the value for the leafref wouldn't match the restrictions for a target but instead just say the leafref target wasn't found.
The only data that should indicate the error message for data type restrictions is data associated with the target itself, not leafrefs.
Fixes #2359