Skip to content

Conversation

@rowlesmr
Copy link
Collaborator

from #124

Instrument examples are split between PD_INSTR and PD_INSTR_DETECTOR.

I think the category descriptions need to be updated to point our that the former is source to specimen, and the latter is specimen to detector(s).

@rowlesmr rowlesmr force-pushed the examples-PD_INSTR branch from 44a7656 to 77e5fc4 Compare June 24, 2025 11:24
@rowlesmr
Copy link
Collaborator Author

From #225

Should PD_INSTR have a link to _diffrn_radiation.id?

That will allow an instrument to know what the incident wavelengths are, and coupled with _pd_instr_detector.instr_id (or successor - see #204 shenanigins), it can also find it's detectors, so it knows everything.

@jamesrhester
Copy link
Contributor

Should PD_INSTR have a link to _diffrn_radiation.id?

Yes. I think a new data name in pd_instr is the right way to go.

Co-authored-by: Antanas Vaitkus <antanas.vaitkus90@gmail.com>
Co-authored-by: Antanas Vaitkus <antanas.vaitkus90@gmail.com>
@jamesrhester jamesrhester merged commit 1d5542f into COMCIFS:master Jul 9, 2025
3 checks passed
@rowlesmr rowlesmr deleted the examples-PD_INSTR branch July 11, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants