Return imgCIF to checking workflow #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Merging PR COMCIFS/dictionary_check_action#17 should suppress the esd data name issue. However, additional formal validation messages will should now also appear due to the |
vaitkus
approved these changes
Sep 23, 2025
Collaborator
vaitkus
left a comment
vaitkus
left a comment
There was a problem hiding this comment.
Looks good to me. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that imgCIF has been updated to conform to DDLm style we can return it to the checking workflow. As well as returning imgCIF to the workflow, the present PR: corrects dates; fixes two types that did not match imgCIF; and fixes the imgCIF head category name.
The one remaining error should be the single imgCIF data name that uses
_esdin a SU data name, as do all such mmCIF data names.