Skip to content

Design fix for options on different screen size #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ulises0516 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Design fix for options on different screen size #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions app/dashboard/course/[courseId]/start-session/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import {
getQuestionsForSession,
} from "@/services/session";


export default function StartSession() {
const params = useParams();
const router = useRouter();
Expand Down Expand Up @@ -183,6 +184,7 @@ export default function StartSession() {

const activeQuestion = questions ? questions.find((q) => q.id === activeQuestionId) : null;
const totalVotes = chartData.reduce((sum, item) => sum + item.Votes, 0);


return (
<div className="flex flex-col items-center p-4">
Expand Down Expand Up @@ -213,7 +215,7 @@ export default function StartSession() {
data={chartData}
layout="vertical"
barCategoryGap={20}
margin={{ left: 100, right: 20, top: 20, bottom: 20 }}
margin={{ left: 100, right: 20, top: 0, bottom: 0 }}
>
<XAxis type="number" domain={[0, totalVotes]} hide />
<YAxis
Expand All @@ -222,7 +224,7 @@ export default function StartSession() {
tick={<LetteredYAxisTick />}
tickLine={false}
axisLine={false}
tickMargin={8}
tickMargin={9}
style={{ fill: "#000" }}
/>
<ChartTooltip
Expand Down
57 changes: 33 additions & 24 deletions components/YAxisTick.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,36 +12,45 @@ export function LetteredYAxisTick({ x = 0, y = 0, payload }: EllipsisYAxisTickPr
if (!payload) return null;

const fullText = payload.value;
const maxChars = 15;
const truncated =
fullText.length > maxChars ? fullText.slice(0, maxChars) + " . . . " : fullText;
const maxChars = 10;
const truncated = fullText.length > maxChars ? fullText.slice(0, maxChars) : fullText;

return (
<g transform={`translate(${x},${y})`}>
<text textAnchor="end" fill="#000" dy={4} dx={-2} fontSize={12}>
<text textAnchor="end" fill="#000" dy={4} dx={-2} fontSize={14} fontWeight={"Bold"}>
{truncated}
</text>
{fullText.length > maxChars && (
<foreignObject x={-16.9} y={-6} width={20} height={20}>
<Popover>
<PopoverTrigger asChild>
<button
style={{
background: "none",
border: "none",
cursor: "pointer",
padding: 0,
}}
>
<MoreHorizontal size={16} />
</button>
</PopoverTrigger>
<PopoverContent>
<div style={{ padding: "0.5rem 1rem", whiteSpace: "normal" }}>
{fullText}
</div>
</PopoverContent>
</Popover>
<foreignObject x={-10} y={-12} width={30} height={30}>
<div
style={{
display: "flex",
alignItems: "center",
justifyContent: "center",
width: "100%",
height: "100%",
}}
>
<Popover>
<PopoverTrigger asChild>
<button
style={{
background: "none",
border: "none",
cursor: "pointer",
padding: 0,
}}
>
<MoreHorizontal size={16} />
</button>
</PopoverTrigger>
<PopoverContent>
<div style={{ padding: "0.5rem 1rem", whiteSpace: "normal" }}>
{fullText}
</div>
</PopoverContent>
</Popover>
</div>
</foreignObject>
)}
</g>
Expand Down