-
Notifications
You must be signed in to change notification settings - Fork 1
chore(dependabot): ignore patch updates #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @felixpalmer, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to optimize the dependency update workflow by instructing Dependabot to disregard patch-level version updates. The primary goal is to decrease notification fatigue and allow maintainers to focus on more impactful dependency changes, such as minor and major version bumps, without being overwhelmed by frequent, small updates. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to reduce notifications from Dependabot by ignoring all patch-level updates. While this will reduce the number of pull requests, it introduces a critical security risk. The proposed configuration will cause Dependabot to ignore security fixes that are released as patch versions, potentially leaving the project exposed to known vulnerabilities. I have added a critical comment explaining the risk and recommending the removal of this change.
| - dependency-name: "*" | ||
| update-types: ["version-update:semver-patch"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change introduces a significant security risk. By ignoring all patch-level updates (version-update:semver-patch) for all dependencies (*), you will also be ignoring security updates that are released as patch versions. The Dependabot documentation states that ignore rules apply to both version updates and security updates. This could leave your project vulnerable to known exploits.
It is highly recommended to remove this configuration. If the goal is to reduce the number of pull requests from Dependabot, consider using update grouping instead to combine multiple updates into a single pull request.
To reduce the dependabot notices, ignore patch releases