On initial upgrade to 2.41.3, force all cards to ISO-8859-1 #2937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLastProject
force-pushed
the
fix/enforce_iso_on_2.41.3_upgrade
branch
4 times, most recently
from
1b9735a to
024f685
Compare
This fixes old pkpass files imported before Catima 2.41.0 to be forced to "Automatic", which may guess UTF-8. New pkpass files will have the encoding read from the file and newly scanned barcodes will use Automatic. This does have the unfortunate side effect of everyone who already scanned a QR code with UTF-8 data since Catima 2.41.0 to have it forced to ISO-8859-1, but it will fix Deutschlandtickets imported before 2.41.0 which is a rather large amount of the Catima userbase.
This will not catch one edge case: use exporting a backup in Catima 2.41.0 - 2.41.2, then uninstall Catima, then installing Catima 2.41.3 and then importing the database. But this seems rare enough to be acceptable.
TheLastProject
force-pushed
the
fix/enforce_iso_on_2.41.3_upgrade
branch
from
024f685 to
90e6dd8
Compare
rugk
reviewed
Jan 4, 2026
|
|
||
| // On upgrade to 2.41.3, force all existing "Automatic" cards to ISO-8859-1. | ||
| // UTF-8 support was only added in 2.42.0, before that, all barcodes were saved without | ||
| // any encoding info. As many scanners deal badly with ECI info, automatically guessing |
There was a problem hiding this comment.
If I understand that correctly, to further prevent such problems and be better to debug/fix it later, maybe an idea would be to store the version of Catima that was used for scanning/importing a particular code/file? So you could fix only the broken ones, then?
Or some internal "scan/import logic" version counter or so?
Member
Author
There was a problem hiding this comment.
Not a bad suggestion. I'll think of this later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes old pkpass files imported before Catima 2.41.0 to be forced to "Automatic", which may guess UTF-8. New pkpass files will have the encoding read from the file and newly scanned barcodes will use Automatic.
This does have the unfortunate side effect of everyone who already scanned a QR code with UTF-8 data since Catima 2.41.0 to have it forced to ISO-8859-1, but it will fix Deutschlandtickets imported before 2.41.0 which is a rather large amount of the Catima userbase.