Skip to content

Closes #432: Replace buggy pig rank function with custom solution #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marekhorst wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Closes #432: Replace buggy pig rank function with custom solution #433

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ...-similarity/document-similarity-logic/src/main/pig/document-similarity-s1-rank_filter.pig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,13 @@ store tcX into '$outputPath$TERM_COUNT';
--**************** word count rank *****************
tc = load '$outputPath$TERM_COUNT' as (val:double);
wc = foreach group_by_terms generate COUNT(terms) as count, group as term;
wc_ranked = rank wc by count asc;
store wc_ranked into '$outputPath$WORD_RANK_HR';

-- git#432 replacing buggy pig rank function with custom solution taken from document-similarity-s1-ship-rank_filter.pig
-- wc_ranked = rank wc by count asc;
-- store wc_ranked into '$outputPath$WORD_RANK_HR';
wc_tmp = order wc by count asc parallel 1;
STORE wc_tmp INTO '$outputPath$WORD_RANK_HR' using pl.edu.icm.coansys.similarity.pig.serializers.RankStorage();
wc_ranked = LOAD '$outputPath$WORD_RANK_HR' as (rank_num:long, count:long, term:chararray);

term_condition_accepted_tmp = filter wc_ranked by ($0 <= (double)tc.val*$removal_rate and $0 >= $removal_least_used);
term_condition_accepted_tmp_joined_with_docs = join term_condition_accepted_tmp by term, doc_all by term;
Expand Down