Skip to content

Conversation

@RebeccaBorgqvist
Copy link

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@RebeccaBorgqvist RebeccaBorgqvist marked this pull request as draft June 12, 2024 13:01
@RebeccaBorgqvist RebeccaBorgqvist marked this pull request as ready for review June 12, 2024 13:11
from .api import fetch_mac, get_ip
from .const import DOMAIN

API_DEFAULT = "http://ctek-ng-air.local/meter/"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer needed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

from .api import fetch_mac, get_ip
from .const import DOMAIN

API_DEFAULT = "http://ctek-ng-air.local/meter/"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not here, but below. Conflig flow do not have a reason to use the API url any more?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

"""Return the state of the sensor."""
data = self.coordinator.data
if data is None:
if data is None or isinstance(data, dict):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why filter out dicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants