Skip to content

Require non-empty items field for checkout #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
idrisregg wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Require non-empty items field for checkout #11

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84f80f9
Require non-empty items field for checkout
idrisregg Dec 14, 2025
fc7565e
Update client.ts
idrisregg Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/classes/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,20 @@ export class ChargilyClient {
);
}

// require either a non-empty items array or both amount and currency, This prevents empty items arrays from bypassing validation.
const hasItems =
Array.isArray(checkout_data.items) &&
checkout_data.items.length > 0;

const hasAmountAndCurrency =
typeof checkout_data.amount === 'number' &&
typeof checkout_data.currency === 'string';

if (!hasItems && !hasAmountAndCurrency) {
throw new Error(
'Either a non-empty items array or both amount and currency must be provided.'
);
}
return this.request('checkouts', 'POST', checkout_data);
}

Expand Down