Update from upstream #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workflows tests, use pyproject
resolve docker-compose command not found
resolve docker-compose command not found
ignore the test that indicates if the device hosts an expension card
temporarily skip Codecov integration
Handle missing driver in storage device configuration data
Handle missing pvid in LLDP VLAN data
Virtualmachine corrections
```
lldp.eth0.vlan.vlan-id=300
lldp.eth0.vlan.pvid=yes
lldp.eth0.vlan=VLAN300
```
```
Version: lldpd 1.0.11
```
```
{'300': {'pvid': True}, 'VLAN300': {}}
Traceback (most recent call last):
File "/root/.local/bin/netbox_agent", line 8, in <module>
sys.exit(main())
File "/root/.local/lib/python3.10/site-packages/netbox_agent/cli.py", line 44, in main
return run(config)
File "/root/.local/lib/python3.10/site-packages/netbox_agent/cli.py", line 39, in run
server.netbox_create_or_update(config)
File "/root/.local/lib/python3.10/site-packages/netbox_agent/server.py", line 292, in netbox_create_or_update
self.network.create_or_update_netbox_network_cards()
File "/root/.local/lib/python3.10/site-packages/netbox_agent/network.py", line 417, in create_or_update_netbox_network_cards
ret, interface = self.reset_vlan_on_interface(nic, interface)
File "/root/.local/lib/python3.10/site-packages/netbox_agent/network.py", line 234, in reset_vlan_on_interface
pvid_vlan = [key for (key, value) in lldp_vlan.items() if value['pvid']]
File "/root/.local/lib/python3.10/site-packages/netbox_agent/network.py", line 234, in <listcomp>
pvid_vlan = [key for (key, value) in lldp_vlan.items() if value['pvid']]
KeyError: 'pvid'
```
Fix KeyError: 'pvid' in lldp.py
Update dependency packaging to v24
pynetbox 7.3.4 depends on packaging<24.0
generate only one Codecov report
Previously only TAP/TUN were tagged as such, other virtuals were tagged as "Other"
Network identifier is used to match discovered NICs with Netbox interfaces. This field won't be updated. Changes to it will cause the interface to be re-created.
Not set at all on IPMI
Network interfaces improvements
Network interfaces
Fallback to platform names with less info
"Multigig" interfaces (supporting 2.5G or 5G max speeds) are BaseT only (the SFP+ interface standard always supports 10G as max), so we don't need to check if these ports are a fiber media type
Add support for 2.5GBASE-T and 5GBASE-T interface types
Handle os-release without version or codename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.