Skip to content

Conversation

@wjohnald
Copy link
Contributor

@wjohnald wjohnald commented Jan 8, 2026

Citrine Python PR

Description

Please briefly explain the goal of the changes/this PR.
The reviewer should be able to understand why the change is being made by reading this description
and its links (e.g. JIRA tickets).

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance (non-breaking change to assist developers)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in __version__.py

url = format_escaped_url(
"http://base.com/{}/{}/{word1}/{word2}", 1, "&", word1="fine", word2="+/?#"
)
assert "http://base.com/" in url

Check failure

Code scanning / CodeQL

Incomplete URL substring sanitization High test

The string
http://base.com/
may be at an arbitrary position in the sanitized URL.

Copilot Autofix

AI 9 days ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants