You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@subaha-cob you dont need to do any of this to upload icons to patterns.
Icons are just served as part of the CDN, and are not included in the build processes. So, these icons just need to be added to the s3 patterns bucket.
I am not sure where the config file gets upadted, it could be part of an automated process which runs on the s3 bucket (a file watcher from AWS Lambda) - in which case your changes will be overwritten.
The change to the testcafe config file looks like it might be a code fix though, so that might be worth committing if needed.
In summary, I don't think this update is needed b/c you have uploaded the files to the directory.
@subaha-cob you dont need to do any of this to upload icons to patterns. Icons are just served as part of the CDN, and are not included in the build processes. So, these icons just need to be added to the s3 patterns bucket. I am not sure where the config file gets upadted, it could be part of an automated process which runs on the s3 bucket (a file watcher from AWS Lambda) - in which case your changes will be overwritten. The change to the testcafe config file looks like it might be a code fix though, so that might be worth committing if needed.
In summary, I don't think this update is needed b/c you have uploaded the files to the directory.
This was something I believe Phil was doing. I also realized it was needed afterwords.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DIG-6237 Add new svg icons to Patterns