Handle slides for empty presentation #200
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of some recent S3 changes, we added a couple of functions to generate/get slide URLs for presentation display. One of these clauses takes a presentation file and calls the 2-arity version of the function:
The implicit assumption I made was that a
PresentationFilestruct would always represent an existing presentation with a non-nilhashand a non-zerolength. That's not the case and we've found in production that the 2-arity function is being called asget_slide_urls(nil, 0). This PR adds that clause returning an empty list, which fits what the LiveViews are happy to handle right now.