Fix OIDC PKCE #202
Open
Fix OIDC PKCE #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I actually found another fix that allows Microsoft Entra to work with PKCE and allows more oidcc custom configuration by adding an OIDC_DOC_OVERRIDE. That branch is here: https://github.com/nmbgeek/Claper/tree/oidcc-override Does the code look good and the updated .env.sample? If so I can close this and open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes OIDC for non PKCE providers as mentioned in #195
Adds new env variable OIDC_USE_PKCE with true or false based on OIDC provider support.